Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bindings.bind always sets allow_forward to True #74

Closed
SamStudio8 opened this issue Aug 24, 2021 · 2 comments
Closed

Bindings.bind always sets allow_forward to True #74

SamStudio8 opened this issue Aug 24, 2021 · 2 comments

Comments

@SamStudio8
Copy link

SamStudio8 commented Aug 24, 2021 •
edited

Hi @willmcgugan, I think this might be a bug but apologies for the issue if this is intentional for now. It seems that the bind function of the Bindings class ignores the allow_forward argument and always sets forwarding to True.

https://github.com/willmcgugan/textual/blob/f1107a19a9298f991bebd48a8b445ba31db7b318/src/textual/binding.py#L47
@willmcgugan
Copy link
Collaborator

Yeah, that should duplicate the argument there.

@SamStudio8
Copy link
Author

I see that's fixed by 577ef6b now, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@willmcgugan @SamStudio8