Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate L-BFGS-B from scipy #9

Open
alexjc opened this issue Jun 20, 2020 · 0 comments
Open

Integrate L-BFGS-B from scipy #9

alexjc opened this issue Jun 20, 2020 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@alexjc
Copy link
Collaborator

alexjc commented Jun 20, 2020

The PyTorch implementation of L-BFGS in torch.optim.LBFGS is fast, however, it does not seem to be as reliable as the one in SciPy.
https://docs.scipy.org/doc/scipy/reference/generated/scipy.optimize.fmin_l_bfgs_b.html

What needs doing?

  • Create a new Solver in solver.py that includes scipy's L-BFGS.
  • Compare reliability with PyTorch version on a diverse dataset of textures.

What's the challenge?

  • Ensure that scipy module is not required, only imported locally when necessary.
  • Ensure the solver works with both CUDA and CPU tensors.
@alexjc alexjc added enhancement New feature or request good first issue Good for newcomers labels Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexjc