Roundcube 1.5 & Nextcloud calendar

[quenenni]

Hello,

I installed the plugin on my Roundcube v1.5 and I'm trying to have Nextcloud agendas available.

Nextcloud and Roundcube are setup with LemonLdap SSO, but as I read here in a ticket from rcmcarddav plugin (mstilkerich/rcmcarddav#319 / plugin used by this one to access Nextcloud Dav frontend if I'm correct), I need to use the OIDC plugin instead of the SAML one in Nextcloud if I can hope to make it works.. that's for later.
For now, I tested with apps generated access in Nextcloud.

As I showed in this ticket (#22), I installed the plugin manually.
I hope I didn't forget a step. But the calendars seems to work fine.

I can successfully add a calendar from our Nextcloud.

I can see the entries from the Nc calendar, I can edit them or add new one in Roundcube or in Nextcloud and they sync both ways..
Very very nice.

The problems I have:

• I see the entries only in the monthly view. When I click on the weekly or daily view, I have this error in my FF console:

Uncaught TypeError: seg is undefined
    renderFgSegEls https://rouncube.domain.tld/plugins/calendar/lib/js/fullcalendar.js?s=1612377324:4364
    jQuery 2
    renderFgSegEls https://rouncube.domain.tld/plugins/calendar/lib/js/fullcalendar.js?s=1612377324:4360
    renderFgRanges https://rouncube.domain.tld/plugins/calendar/lib/js/fullcalendar.js?s=1612377324:4284
    render https://rouncube.domain.tld/plugins/calendar/lib/js/fullcalendar.js?s=1612377324:4273
    executeEventRender https://rouncube.domain.tld/plugins/calendar/lib/js/fullcalendar.js?s=1612377324:8847
    executeEventRender https://rouncube.domain.tld/plugins/calendar/lib/js/fullcalendar.js?s=1612377324:11531
    requestEventsRender https://rouncube.domain.tld/plugins/calendar/lib/js/fullcalendar.js?s=1612377324:3731
    runTask https://rouncube.domain.tld/plugins/calendar/lib/js/fullcalendar.js?s=1612377324:8671
    runRemaining https://rouncube.domain.tld/plugins/calendar/lib/js/fullcalendar.js?s=1612377324:8563
    tryStart https://rouncube.domain.tld/plugins/calendar/lib/js/fullcalendar.js?s=1612377324:8551
    resume https://rouncube.domain.tld/plugins/calendar/lib/js/fullcalendar.js?s=1612377324:8542
    stopBatchRender https://rouncube.domain.tld/plugins/calendar/lib/js/fullcalendar.js?s=1612377324:3581
    renderView https://rouncube.domain.tld/plugins/calendar/lib/js/fullcalendar.js?s=1612377324:9628
    changeView https://rouncube.domain.tld/plugins/calendar/lib/js/fullcalendar.js?s=1612377324:9407
    buttonClick https://rouncube.domain.tld/plugins/calendar/lib/js/fullcalendar.js?s=1612377324:12604
    buttonEl https://rouncube.domain.tld/plugins/calendar/lib/js/fullcalendar.js?s=1612377324:12640
    jQuery 8
    new_btn https://rouncube.domain.tld/plugins/calendar/calendar_ui.js?s=1612377324:4261
    jQuery 8
    <anonymous> https://rouncube.domain.tld/plugins/calendar/calendar_ui.js?s=1612377324:4259
    jQuery 2
    <anonymous> https://rouncube.domain.tld/plugins/calendar/calendar_ui.js?s=1612377324:4246
    triggerEvent https://rouncube.domain.tld/program/js/common.min.js?s=1625341187:28
    init https://rouncube.domain.tld/program/js/app.min.js?s=1625341187:35
    <anonymous> https://rouncube.domain.tld/?_task=calendar&view=month&date=1628107635:747
    jQuery 13

• when I have several entries on the same day, in the monthly view at least, whatever entry I'm clicking on to edit, it's always the same entry that popup.

[quenenni]

I modified the code to see how it goes.
In the file plugins/calendar/lib/js/fullcalendar.js, line 4363:

if (hasEventRenderHandlers && typeof seg !== 'undefined') {

And on line 4366:

if (el && typeof seg !== 'undefined') {

With this, weekly and daily view are working.

New small rendering problems showed up:
It seems that the first 2 entries are correctly renderred and at the right place.
But after that, from the third, all the new entries, in the monthly view, are on the same day and in the daily view, they are all stacked under the third entry.
The category color css also starts to have problem from the third entry.
Manipulating entries with occurrences, like editing it and changing the number of occurrences or switching it off (and so deleting all the future one) works partially.

Also, when creating a new entry, it selects the anniversary calendar by default. If I validate there is a generic error msg in Roundcube and in the JS console:

Uncaught TypeError: t is null
    triggerEvent https://mail.nubo.name/program/js/common.min.js?s=1625341187:28
    http_response https://mail.nubo.name/program/js/app.min.js?s=1625341187:35
    success https://mail.nubo.name/program/js/app.min.js?s=1625341187:35
    jQuery 6
    http_request https://mail.nubo.name/program/js/app.min.js?s=1625341187:35
    http_post https://mail.nubo.name/program/js/app.min.js?s=1625341187:35
    update_event https://mail.nubo.name/plugins/calendar/calendar_ui.js?s=1612377324:2528
    save_func https://mail.nubo.name/plugins/calendar/calendar_ui.js?s=1612377324:910
    jQuery 23
    event_edit_dialog https://mail.nubo.name/plugins/calendar/calendar_ui.js?s=1612377324:954
    select https://mail.nubo.name/plugins/calendar/calendar_ui.js?s=1612377324:3715
    publiclyTrigger https://mail.nubo.name/plugins/calendar/lib/js/fullcalendar.js?s=1628101559:9355
    publiclyTrigger https://mail.nubo.name/plugins/calendar/lib/js/fullcalendar.js?s=1628101559:8783
    triggerSelect https://mail.nubo.name/plugins/calendar/lib/js/fullcalendar.js?s=1628101559:3989
    reportSelection https://mail.nubo.name/plugins/calendar/lib/js/fullcalendar.js?s=1628101559:3984
    interactionEnd https://mail.nubo.name/plugins/calendar/lib/js/fullcalendar.js?s=1628101559:11273
    trigger https://mail.nubo.name/plugins/calendar/lib/js/fullcalendar.js?s=1628101559:5866
    handleInteractionEnd https://mail.nubo.name/plugins/calendar/lib/js/fullcalendar.js?s=1628101559:5730
    handleInteractionEnd https://mail.nubo.name/plugins/calendar/lib/js/fullcalendar.js?s=1628101559:2440
    endInteraction https://mail.nubo.name/plugins/calendar/lib/js/fullcalendar.js?s=1628101559:5725
    i jQuery
    intercept https://mail.nubo.name/plugins/calendar/lib/js/fullcalendar.js?s=1628101559:1535
    jQuery 4
    trigger https://mail.nubo.name/plugins/calendar/lib/js/fullcalendar.js?s=1628101559:1557
    handleMouseUp https://mail.nubo.name/plugins/calendar/lib/js/fullcalendar.js?s=1628101559:2260