Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions for Simplification #542

Open
decentralgabe opened this issue Jan 6, 2022 · 3 comments
Open

Suggestions for Simplification #542

decentralgabe opened this issue Jan 6, 2022 · 3 comments
Labels
documentation & logging Everything which contributes to the better understanding of this project. help wanted Extra attention is needed

Comments

@decentralgabe
Copy link
Contributor

Describe the solution you'd like

Config

  1. Combine founders_map and owners_map. I'm curious how necessary having both is. I can see a potential argument made for bakers that have both founders and owners wanting to first compensate founders, and then owners. Do people actually use that? Could they be combined?
  2. Combine specials_map and supporters_set. The only real difference here is the implicit 0 service fee, which could be set manually in the specials_map.

Misc

Can the Dexter code be removed? Does Dexter exist anymore?

@decentralgabe decentralgabe added the enhancement New feature or request label Jan 6, 2022
@ericlavoie
Copy link
Contributor

Founders_map and Owners_map.
It is needed to be separate, founders refers to the distribution ratio for the service fees collected (fees the bakers charge) the owners map distributes the rewards for funds according to the ratio that was contributed by each owner.
I actually use it personally. It is for tax reason we split service fees a different way.

Read carefully the documentation.
Special maps and supported set could be, by setting it to 0, the pain versus the gain of removing the correct reference in the code, may not had more functionality, and may be detrimental for older installation, you will have to retain backward compatibility for all config that use it.

@decentralgabe
Copy link
Contributor Author

thanks for the input. I did read the documentation but had to read it 2-3 times to fully understand it.

@ericlavoie
Copy link
Contributor

It took me a few read.

@jdsika jdsika added help wanted Extra attention is needed documentation & logging Everything which contributes to the better understanding of this project. and removed enhancement New feature or request labels Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation & logging Everything which contributes to the better understanding of this project. help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants