Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loop stuck when baker not active in payment cycle #616

Open
redref opened this issue Sep 5, 2022 · 0 comments · May be fixed by #707
Open

Loop stuck when baker not active in payment cycle #616

redref opened this issue Sep 5, 2022 · 0 comments · May be fixed by #707
Assignees
Labels
bug Something isn't working

Comments

@redref
Copy link
Contributor

redref commented Sep 5, 2022

Describe the bug
TRD tries to compute on payment cycle, but get stuck on this cycle if baker was not active (no delegators, no rewards) for this cycle.

To Reproduce

  1. Bootstrap a new baker address
  2. Start TRD
  3. TRD should be stuck at payment cycle (current - 3 - X)

Expected behavior
Payment computations should proceed to next cycle in this case.

Screenshots

2022-09-02 13:31:46,773 - producer  - ERROR - [try_to_pay] API provider error Max sequent calls number exceeded (256)
2022-09-02 13:31:46,774 - producer  - ERROR - tzkt error at payment producer loop: 'Max sequent calls number exceeded (256)', will try again.

Environment

  • Docker
  • Both (tested in testnet)
  • python src/main.py --network GHOSTNET --base_directory /var/run/tezos/trdconfig --reward_data_provider tzkt --signer_endpoint http://127.0.0.1:6732 --node_endpoint <endpoint> --docker --dry_run --payment_offset 20 --release_override 0
  • Alpine 3.16

Additional context
I have pinpointed issue to the TZKT api response NO_CONTENT treatment.
https://github.com/tezos-reward-distributor-organization/tezos-reward-distributor/blob/master/src/tzkt/tzkt_api.py#L89
https://github.com/tezos-reward-distributor-organization/tezos-reward-distributor/blob/master/src/tzkt/tzkt_api.py#L194

It seems TZKT return 204 in this case (no delegators, no rewards) for this cycle. This is processed as a request error, and looping indefinitely on this cycle as a result.

@redref redref added the bug Something isn't working label Sep 5, 2022
@jdsika jdsika added this to the v11.0 (Ithaca) milestone Sep 6, 2022
@jdsika jdsika modified the milestones: v11.0 (Lima), v11.5 (Lima) Dec 18, 2022
@TPXP TPXP linked a pull request Jul 2, 2024 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants