Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to add implementations for unknown layers #120

Closed
mats-claassen opened this issue Jan 31, 2018 · 3 comments
Closed

Possibility to add implementations for unknown layers #120

mats-claassen opened this issue Jan 31, 2018 · 3 comments
Assignees
Labels
enhancement Improvement to existing functionality (type)

Comments

@mats-claassen
Copy link

Hi, what do you think of the idea of having a parameter in the convert function were the user can pass a function that handles potential unsupported layers?

What I have in mind is something like torch2coreml has with the unknown_layer_converter_fn parameter.

@aseemw aseemw self-assigned this Jan 31, 2018
@aseemw
Copy link
Collaborator

aseemw commented Jan 31, 2018

Just to understand it correctly, the "unknown_layer_converter_fn" allows to insert custom layers in the CoreML graph, right?

Yes, a flag along the lines of the "add_custom_layers" Flag, as in the coremltools Keras converter, would be added.

@mats-claassen
Copy link
Author

Actually I think there are two types of unknown layers. First, the one you mention which tackles those layers that CoreML does not support so that they have to be implemented in Swift. The other is for those layers that tf-coreml doesn't support, i.e. does not convert to CoreML. I think both cases would be helpful.

@aseemw
Copy link
Collaborator

aseemw commented May 21, 2018

PR #179 adds the ability to add custom layer proto messages during conversion.

@aseemw aseemw closed this as completed May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to existing functionality (type)
Projects
None yet
Development

No branches or pull requests

2 participants