Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lines remain on canvas after screen clear #7

Closed
5k3105 opened this issue Sep 14, 2018 · 4 comments
Closed

Lines remain on canvas after screen clear #7

5k3105 opened this issue Sep 14, 2018 · 4 comments

Comments

@5k3105
Copy link

5k3105 commented Sep 14, 2018

Example both here: https://github.com/5k3105/slowdraw1 and here: https://github.com/5k3105/tilemap4

Artifacts remain on screen after scale/clear/redraw. This is windows 7.

@tfriedel6
Copy link
Owner

I can't see what's wrong with the slowdraw1 example, but in tilemap4 I can see the lines remaining when scaling with the mouse wheel. But that's because the FillRect call is also scaled, so it doesn't actually draw over everything.

What you would have to do is do the FillRect call before the Scale and Translate calls. Also, transformations (like Scale and Translate) are cumulative, so if you call Scale(0.5, 0.5) twice, you get the same as calling Scale(0.25, 0.25). This also works across frames. So what you have to do is call Save() before doing the transformations, then Restore() after all the drawing (or use defer).

Hope that helps

@5k3105
Copy link
Author

5k3105 commented Sep 17, 2018

I moved the 'clear screen' to the top like you said and that fixed it (https://github.com/5k3105/tilemap5).
Still see line drawn beneath on slowdraw (https://github.com/5k3105/slowdraw2).
Are you also using win7?

@tfriedel6
Copy link
Owner

I tried it under Linux and Win10 and it looks the same, but I don't have a Win7 installation to test on.

But I'm not sure what I should be seeing. At the moment there is a square being drawn from the top and bottom centers toward the side centers. Just before the square closes, it all gets cleared and starts over. Is that correct?

@5k3105
Copy link
Author

5k3105 commented Sep 18, 2018

Yes. But I continue to see a square beneath - it doesn't seem to clear. If it works on win10 I will assume it's something particular with my machine. Thanks!

@5k3105 5k3105 closed this as completed Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants