Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify rule before uploading #30

Closed
manne opened this issue Jan 28, 2019 · 1 comment · Fixed by #32
Closed

Verify rule before uploading #30

manne opened this issue Jan 28, 2019 · 1 comment · Fixed by #32
Labels
enhancement New feature or request

Comments

@manne
Copy link
Contributor

manne commented Jan 28, 2019

Given a rule containing (only a parentheses)

(

When adding the rule
and mapping the rule
Then no errors occurs

Actual

Upload

No error occurs

Runtime

When the rule is invoked
then following error occurs

 [Warning] Rule 'Invalid' failed: (1,2): error CS1733: Expected expression

Expected

The CLI should not allow to upload invalid rules (according to the rule language), an error should be produced

@giuliov
Copy link
Member

giuliov commented Jan 28, 2019

I like the suggestion but I think that the recently added invoke.rule command allows one to check for such error before uploading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants