Weird errors in v1.4

[patlecat]

I installed the lib via vcpkg where it didn't throw any errors. But when I execute the example code from you I get 16 errors (s. below).

• I use msvc2019 with Win10, x64, C++17

0>D:\vcpkg\installed\x64-windows\include\xlnt\utils\numeric.hpp(65,61): Error C2146: syntax error: missing ')' before identifier 'lval' (compiling source file manage_mailcow.cpp)
0>D:\vcpkg\installed\x64-windows\include\xlnt\utils\numeric.hpp(65,61): Error C2365: 'NumberL': redefinition; previous definition was 'template parameter' (compiling source file manage_mailcow.cpp)
0>D:\vcpkg\installed\x64-windows\include\xlnt\utils\numeric.hpp(65,61): Error C2061: syntax error: identifier 'lval' (compiling source file manage_mailcow.cpp)
0>D:\vcpkg\installed\x64-windows\include\xlnt\utils\numeric.hpp(65,61): Error C2059: syntax error: ')' (compiling source file manage_mailcow.cpp)
0>D:\vcpkg\installed\x64-windows\include\xlnt\utils\numeric.hpp(65,61): Error C2146: syntax error: missing ')' before identifier 'rval' (compiling source file manage_mailcow.cpp)
0>D:\vcpkg\installed\x64-windows\include\xlnt\utils\numeric.hpp(65,61): Error C2146: syntax error: missing ';' before identifier 'rval' (compiling source file manage_mailcow.cpp)
0>D:\vcpkg\installed\x64-windows\include\xlnt\utils\numeric.hpp(66,1): Error C2143: syntax error: missing ';' before '{' (compiling source file manage_mailcow.cpp)
0>D:\vcpkg\installed\x64-windows\include\xlnt\utils\numeric.hpp(66,1): Error C2447: '{': missing function header (old-style formal list?) (compiling source file manage_mailcow.cpp)
0>D:\vcpkg\installed\x64-windows\include\xlnt\utils\numeric.hpp(74,61): Error C2146: syntax error: missing ')' before identifier 'lval' (compiling source file manage_mailcow.cpp)
0>D:\vcpkg\installed\x64-windows\include\xlnt\utils\numeric.hpp(74,61): Error C2365: 'NumberL': redefinition; previous definition was 'template parameter' (compiling source file manage_mailcow.cpp)
0>D:\vcpkg\installed\x64-windows\include\xlnt\utils\numeric.hpp(74,61): Error C2061: syntax error: identifier 'lval' (compiling source file manage_mailcow.cpp)
0>D:\vcpkg\installed\x64-windows\include\xlnt\utils\numeric.hpp(74,61): Error C2059: syntax error: ')' (compiling source file manage_mailcow.cpp)
0>D:\vcpkg\installed\x64-windows\include\xlnt\utils\numeric.hpp(74,61): Error C2146: syntax error: missing ')' before identifier 'rval' (compiling source file manage_mailcow.cpp)
0>D:\vcpkg\installed\x64-windows\include\xlnt\utils\numeric.hpp(74,61): Error C2146: syntax error: missing ';' before identifier 'rval' (compiling source file manage_mailcow.cpp)
0>D:\vcpkg\installed\x64-windows\include\xlnt\utils\numeric.hpp(75,1): Error C2143: syntax error: missing ';' before '{' (compiling source file manage_mailcow.cpp)
0>D:\vcpkg\installed\x64-windows\include\xlnt\utils\numeric.hpp(75,1): Error C2447: '{': missing function header (old-style formal list?) (compiling source file manage_mailcow.cpp)

[mateusz-talma]

If you using WinAPI you can have problem with macros "min" and "max". Try use:

#undef min
#undef max

before include xlnt header

[patlecat]

Yeah that did the trick, but it's not feeling secure since min or max macros could be defined in any library. Can't you prefix them with something and just detect if msvc is used?

[tfussell]

This has bitten several people already so I'll try to come up with a better solution such as adding a prefix.

[eurake]

If you using WinAPI you can have problem with macros "min" and "max". Try use:

#undef min
#undef max

before include xlnt header

good job