Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spammy console.log of NaN in descent.ts #352

Open
andoppomny opened this issue Mar 14, 2024 · 0 comments
Open

Spammy console.log of NaN in descent.ts #352

andoppomny opened this issue Mar 14, 2024 · 0 comments

Comments

@andoppomny
Copy link

The following from descent.ts:

                    if (!isFinite(gs))
                        console.log(gs);

sometimes causes an excessive amount of console logging of NaN for me, causing me to have to kill the browser tab.
Probably there shouldn't be log statements in this library, but if there has to be, they should have helpful messages. Could it throw an exception instead?

I'm using cytoscape.js with the cytoscape-cola plugin. I use Vite dev server, and the problem seems to be triggered sometimes after a hot reload. So I'm not considering this a true bug in webcola, just a situation that shouldn't arise that isn't handled well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant