Fix issue with select(0) (#2711)

* Fix issue with select(0). Fixes #2658
knex · Jul 13, 2018 · 0f4c9bd · 0f4c9bd
1 parent 6f11eb1
commit 0f4c9bd
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/src/query/builder.js b/src/query/builder.js
@@ -120,7 +120,7 @@ assign(Builder.prototype, {
   // Adds a column or columns to the list of "columns"
   // being selected on the query.
   columns(column) {
-    if (!column) return this;
+    if (!column && column !== 0) return this;
     this._statements.push({
       grouping: 'columns',
       value: helpers.normalizeArr.apply(null, arguments),

diff --git a/test/unit/query/builder.js b/test/unit/query/builder.js
@@ -8139,4 +8139,14 @@ describe('QueryBuilder', function() {
       );
     });
   });
+
+  it('Can call knex.select(0)', function() {
+    testquery(qb().select(0), {
+      pg: 'select 0',
+      mysql: 'select 0',
+      mssql: 'select 0',
+      'pg-redshift': 'select 0',
+      oracledb: 'select 0',
+    });
+  });
 });