Istanbul -> NYC (#2700)

* istanbul -> nyc

.gitignore

@@ -20,6 +20,7 @@ bin/db.sqlite3
 # Bench stuff
 test/bench/temp
 test/coverage/*
+.nyc_output
 
 #VsCode workspace
 .vscode

.travis.yml

@@ -37,8 +37,8 @@ before_script:
 script:
   - if [ -z $TEST_ORACLEDB ]; then npm test; else npm run oracledb:test; fi
 
-after_script:
-  - if [ -z $TEST_ORACLEDB ]; then npm run-script coveralls; fi
+after_success:
+  - if [ -z $TEST_ORACLEDB ]; then npm run coveralls; fi
 
 notifications:
   email: false

package.json

@@ -39,12 +39,12 @@
     "babel-plugin-transform-runtime": "^6.23.0",
     "babel-preset-env": "^1.7.0",
     "chai": "^4.1.2",
-    "coveralls": "~3.0.2",
+    "coveralls": "^3.0.2",
     "eslint": "5.0.1",
     "eslint-config-prettier": "^2.9.0",
     "eslint-plugin-import": "^2.13.0",
     "husky": "^0.14.3",
-    "istanbul": "^0.4.5",
+    "nyc": "^12.0.2",
     "json-loader": "^0.5.7",
     "lint-staged": "^7.2.0",
     "mocha": "^3.5.3",
@@ -78,17 +78,17 @@
     "precommit": "lint-staged",
     "format": "prettier --write \"{src,bin,scripts,test}/**/*.js\"",
     "build": "npm run babel",
-    "debug_test": "node-debug _mocha -t 0 test/index.js",
+    "debug_test": "node --inspect-brk ./node_modules/.bin/_mocha -t 0 test/index.js",
     "babel": "rimraf ./lib && babel src --out-dir lib --copy-files",
-    "coveralls": "cat ./test/coverage/lcov.info | ./node_modules/coveralls/bin/coveralls.js",
+    "coveralls": "nyc report --reporter=text-lcov | coveralls",
     "dev": "rimraf ./lib && babel -w src --out-dir lib --copy-files",
     "lint": "eslint src/**",
     "plaintest": "mocha -t 10000 -b -R spec test/index.js && npm run tape",
     "prepublish": "npm run babel",
     "pre_test": "npm run lint",
     "tape": "node test/tape/index.js | tap-spec",
-    "debug_tape": "node-debug test/tape/index.js",
-    "test": "npm run pre_test && istanbul --config=test/.istanbul.yml cover node_modules/mocha/bin/_mocha -- --check-leaks -t 10000 -b -R spec test/index.js && npm run tape",
+    "debug_tape": "node --inspect-brk test/tape/index.js",
+    "test": "npm run pre_test && nyc mocha --check-leaks -t 10000 -R spec test/index.js && npm run tape",
     "oracledb:test": "docker rmi -f --no-prune knex-test-oracledb && docker build -f scripts/oracle-tests-Dockerfile --tag knex-test-oracledb . && docker run --rm -i -t -e KNEX_TEST_TIMEOUT=$KNEX_TEST_TIMEOUT -e NODE_VER=$NODE_VER knex-test-oracledb",
     "mssql:init": "docker-compose -f scripts/mssql-docker-compose.yml up --no-start && docker-compose -f scripts/mssql-docker-compose.yml start",
     "postmssql:init": "node scripts/wait-for-mssql-server.js && npm run mssql:logs || (npm run mssql:logs;false)",

src/dialects/mysql/transaction.js

@@ -1,14 +1,10 @@
 import Transaction from '../../transaction';
-import inherits from 'inherits';
 import Debug from 'debug';
 import { assign, isUndefined } from 'lodash';
 
 const debug = Debug('knex:tx');
 
-function Transaction_MySQL() {
-  Transaction.apply(this, arguments);
-}
-inherits(Transaction_MySQL, Transaction);
+class Transaction_MySQL extends Transaction {}
 
 assign(Transaction_MySQL.prototype, {
   query(conn, sql, status, value) {

src/dialects/mysql2/transaction.js

@@ -1,13 +1,9 @@
 import Transaction from '../../transaction';
-import inherits from 'inherits';
 const debug = require('debug')('knex:tx');
 
 import { assign, isUndefined } from 'lodash';
 
-function Transaction_MySQL2() {
-  Transaction.apply(this, arguments);
-}
-inherits(Transaction_MySQL2, Transaction);
+class Transaction_MySQL2 extends Transaction {}
 
 assign(Transaction_MySQL2.prototype, {
   query(conn, sql, status, value) {