Bugfix/rollback all wrong order (#3172)

* Fix rollback all bug attempting to perform rollback in chronological order

* Set up second migration to depend on first migration so when rolling back order is tests

* Add test for rollback all only running completed tests in reverse chronological order

src/migrate/Migrator.js

@@ -115,7 +115,17 @@ export default class Migrator {
         .tap((value) =>
           validateMigrationList(this.config.migrationSource, value)
         )
-        .then((val) => (all ? val[0] : this._getLastBatch(val)))
+        .then((val) => {
+          const [allMigrations, completedMigrations] = val;
+
+          return all
+            ? allMigrations
+                .filter((migration) => {
+                  return completedMigrations.includes(migration.file);
+                })
+                .reverse()
+            : this._getLastBatch(val);
+        })
         .then((migrations) => {
           return this._runBatch(migrations, 'down');
         });

test/integration/migrate/index.js

@@ -2,6 +2,7 @@
 'use strict';
 
 const equal = require('assert').equal;
+const fs = require('fs');
 const path = require('path');
 const rimraf = require('rimraf');
 const Promise = require('bluebird');
@@ -461,6 +462,51 @@ module.exports = function(knex) {
       });
     });
 
+    describe('knex.migrate.rollback - all', () => {
+      before(() => {
+        return knex.migrate.latest({
+          directory: ['test/integration/migrate/test'],
+        });
+      });
+
+      it('should only rollback migrations that have been completed and in reverse chronological order', () => {
+        return knex.migrate
+          .rollback(
+            {
+              directory: [
+                'test/integration/migrate/test',
+                'test/integration/migrate/test2',
+              ],
+            },
+            true
+          )
+          .spread(function(batchNo, log) {
+            expect(batchNo).to.equal(1);
+            expect(log).to.have.length(2);
+
+            fs.readdirSync('test/integration/migrate/test')
+              .reverse()
+              .forEach((fileName, index) => {
+                expect(fileName).to.equal(log[index]);
+              });
+
+            return knex('knex_migrations')
+              .select('*')
+              .then(function(data) {
+                expect(data.length).to.equal(0);
+              });
+          });
+      });
+
+      it('should drop tables as specified in the batch', () => {
+        return Promise.map(tables, function(table) {
+          return knex.schema.hasTable(table).then(function(exists) {
+            expect(!!exists).to.equal(false);
+          });
+        });
+      });
+    });
+
     after(function() {
       rimraf.sync(path.join(__dirname, './migration'));
     });

test/integration/migrate/test/20131019235306_migration_2.js

@@ -12,12 +12,22 @@ exports.up = function(knex, promise) {
         t.increments();
         t.string('name');
       })
-    );
+    )
+    .then(() => {
+      return knex.schema.table('migration_test_1', function(t) {
+        t.integer('age');
+      });
+    });
 };
 
 exports.down = function(knex, promise) {
   const tableName2 = knex.userParams.customTableName || 'migration_test_2_1';
   return knex.schema
     .dropTable('migration_test_2')
-    .then(() => knex.schema.dropTable(tableName2));
+    .then(() => knex.schema.dropTable(tableName2))
+    .then(() => {
+      return knex.schema.table('migration_test_1', function(t) {
+        t.dropColumn('age');
+      });
+    });
 };