-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add collate for columns (MySQL) #1147
Conversation
This had been requested in #599 a year ago, but a PR was never created. I have included a test that passed when i ran it.
@rhys-vdw Please have a look at this. |
very useful please add |
@alexrsagen can you add docs for this feature? Otherwise, lgtm |
Also fixed the code example for "comment".
I have no idea how that one check failed, but i'm sure i didn't touch that, and the only thing i just changed was index.html... It said it timed out, so must be slow vm or old Node.js version causing that. If you run the check again i'm sure it'd randomly decide to work... |
I re-triggered the test :) it was just usual timeout when some test doesn't complete in 5000ms... Not sure if there is real problem in somewhere in our codebase or is it just random lagging of travis, which causes it. It happens maybe once in every 20 build or so. |
@elhigu Great, thanks :) I think the timeout issue is more than likely a problem with travis, as they create a very small VM or container for every test they run, so they can't use many resources. Could you or another collaborator merge this please? Currently i'm using |
@alexrsagen code looks fine to me. We are trying to push out 0.10 so I would rather merge this after it is released... we hope to be able to make releases in faster cycle in future. |
@elhigu Ah i see. Thanks for clarifying :) |
Add collate for columns (MySQL)
This had been requested in #599 a year ago, but a PR was never created.
I have included a test that passed when i ran it.