-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add new event query error #1163
Conversation
Looks good, could you add also documentation to index.html for this feature? |
@elhigu Certainly. Is that text sufficient enough? Kinda bad with docs.. Also, I changed the text for the "query" error from |
@@ -2428,10 +2429,33 @@ <h3 id="Interfaces-Events">Events</h3> | |||
<code class="js">knex.select('*') | |||
.from('users') | |||
.on('query', function(data) { | |||
app.log(data); | |||
app.log(data); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does example still look correct in browser? looks like indentation was removed here by an accident.
Docs were nice! Looks like there was some unintentional edits, which maybe could be still fixed? Thanks a lot for this pq 👍 |
Sorry about that, should be fixed now. |
Feature/add new event query error
In the docs, that feature is only mentioned by one short sentence. It's also in the changelog, where I found it. Maybe we can add an example with the global event listener. |
@marcbachmann Not sure what you mean by this. Each event has its own pretty extensive description in the docs, including code examples. Reference |
|
@marcbachmann open pull request with documentation fixes if you feel like it 👍 |
I made these changes back in 2014 (like v0.7?) but it was never merged, unsure why. However, tg and ben both seemed ok with it at the time, so I'm giving it another go. References: #594 #593
Use case example: