Evaluated multi insert default for undefined already in query compiler #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added implementation to work with same principle with every dialect. Now knex.raw('DEFAULT') is not passed until driver, but is already lowered accordingly by query compiler. After this change e.g. invalid use of undefined will be easy to catch in prepBindings (stuff like |
… query compiler for every dialect.
elhigu
force-pushed
the
evaluate-multi-insert-undefined-key-replace-already-in-query-compiler
branch
from
99a375e
to
87a39e4
Compare
elhigu
force-pushed
the
evaluate-multi-insert-undefined-key-replace-already-in-query-compiler
branch
from
87a39e4
to
c935b58
Compare
|
Fixes e.g. |
|
Could @wubuzz / @rhys-vdw check this out at some point... This could be released as a part of 0.11.2 maybe? I just did hit this again and had to downgrade back to 0.10 :| |
|
@elhigu I see nothing wrong with the code, 👍 . I actually kind of prefer |
elhigu
deleted the
evaluate-multi-insert-undefined-key-replace-already-in-query-compiler
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drivers cannot take knex.raw replacement values as positional replacement values, so they must be evaluated already in query compile time to sql string which is passed to driver.