add With Clause #1599
Merged
add With Clause #1599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }).select('*').from('withClause'), { | ||
| mssql: 'with [withClause] as (select [foo] from [users]) select * from [withClause]', | ||
| sqlite3: 'with "withClause" as (select "foo" from "users") select * from "withClause"', | ||
| postgres: 'with "withClause" as (select "foo" from "users") select * from "withClause"', |
There was a problem hiding this comment.
Is it intentional that many of the tests doesn't have oracle / oracledb result checks?
There was a problem hiding this comment.
in oracle the with clause is used in a select subquery.
this could be used in insert but could not find a way to use it with knex (raw or not...)
|
Looks good. I added couple of small comments. Also would be good to add at least one integration test for this. |
Add arguments check to with() and modify some tests
tgriesser
added a commit
that referenced
this pull request
Sep 13, 2016
* master: add With Clause (#1599)
tgriesser
added a commit
that referenced
this pull request
Sep 14, 2016
* master: release 0.12.0 Remove docs, in favor of https://github.com/knex/documentation (#1666) Revert to generic pool (#1665) Fix #1619 Fix use of const in test suite for node 0.12 Moving bin/cli outside of src to allow install from master Deprecate Knex.Promise Simplifying internal client structure add With Clause (#1599) Simplify transaction classes Simplify formatter use Deprecate VERSION, update changelog Fix PG string escaping behavior (#1661)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #716
add a with function(alias, callback|raw)
output:
with "with_alias" as (select * from "books" where "author" = 'Test') select * from "with_alias"