Make quoting identifiers optional.

[ravshansbox]

No description provided.

[elhigu]

Any particular reason why this would be useful feature?

[ravshansbox]

yes, specifically for oracle. In my case with oracle knex.raw('select * from table') works, but knew('table').select() doesn't work, because knex is generating query as select * from "table". AFAIK oracle is case insensitive for unquoted identifiers.

[elhigu]

@atiertant any ideas if this is somehow possible with oracle or should people just write their code case-sensitive way?

[atiertant]

@elhigu we should implement a fromRaw method

[elhigu]

@atiertant I have no idea what you mean by fromRaw method :)

I was trying to ask if this is a good idea to support disabling identifier quoting on oracle or if there are better ways to get around the problem (e.g. some other global setting in database)? Would disabling quotes introduce any other potential problems?

[atiertant]

@elhigu like whereRaw for where clause, you could use fromRaw to add raw in from clause, like this you could do:
knex.select('*').fromRaw('table')

[mxii]

Would be great, would eliminate my problem with table-names including dots. They need to be escaped with quotes and this isn't possible with knex right now.

[ravshansbox]

I'm not sure if fromRaw and whereRaw clauses are best options. How about unquoted column names? Maybe better to implement global option in configuration?

[elhigu]

@ravshansbox I agree that fromRaw doesn't solve this problem at all. It would just add a shortcut for .from(knex.raw(...)) which is not nice either. I would say that if it will be implemented, it would be at first only for oracle dialect and instead of parsing + quoting the identifier it would just validate + use value without quotes to prevent SQL injection stuff.

We may continue this discussion if someone seriously considers implementing / testing / documenting this feature.

[atiertant]

@elhigu @ravshansbox i'm not sure using unquoted column/table name is the best way too... but fromRaw would be at least in the knex spirit and could be useful for many other things...

[elhigu]

@atiertant I'll add it as a separate issue, it is just a missing API which I didn't even knew didn't exist

[jtal]

This a problem for Oracle users. It would be nice to optionally remove the quotes or force the case to upper (as Oracle does for table names).

If not, knex users who have Oracle need to change all of their scripts / queries to use quotes and if they use third party software (for example for reporting) they'll need to contact those companies to ask them to add quotes.

Is there anyone working on this in knex?

[elhigu]

@jtal I don't believe that anyone is working on this. I fail to see the point how 3rd party software generated queries would require changes?

One can run queries like that already by using knex.raw('select * from NonQuotedTableName').

[atiertant]

@elhigu @jtal we could add an option to make formater to not add quote but i'm sure there are many hardcoded quote in the code...

[sant123]

Hi, is there some advance to this issue? Thanks.

[elhigu]

In next release you will be able to create custom quoting functionality #2084

[Gabriel-Aquino]

@elhigu like whereRaw for where clause, you could use fromRaw to add raw in from clause, like this you could do: knex.select('*').fromRaw('table')

Thanks bro! It works for me. I basically have used:

.select()
.fromRaw('myschema.mytable');

and query was wrote as: select * from myschema.mytable.

before it, i was using:
.select()
.from('myschema.mytable');

and query was: select * from "myschema"."mytable" and it was throwing an error.

Now it works. Thank you!!!