Use new safe buffer allocation to conform with deprecation of new Buffer(size)
#1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use of 'new Buffer' has been deprecated in node v6. This swaps the only unsafe buffer allocation in knex with safe allocation. It uses the safe-buffer module to stay backwards compatible with node < v6.
|
Locally the tests pass for me against the default db's. Also for node 0.12.7 . Since it concerns a timeout test (I'll carefully put the blame elsewhere and suggest) it might be the hardware difference? |
|
It was just some random failure. In travis some times DB queries are really slow... btw. CI does run oracle tests automatically with oracledb driver. |
|
Thanks! |
|
Happy to help! Thanks for great module! |
elhigu
pushed a commit
to elhigu/knex
that referenced
this pull request
Feb 15, 2017
Use of 'new Buffer' has been deprecated in node v6. This swaps the only unsafe buffer allocation in knex with safe allocation. It uses the safe-buffer module to stay backwards compatible with node < v6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use of 'new Buffer' has been deprecated in node v6. This swaps the only
deprecated buffer creation in knex with a safe new way of doing allocation. It uses the
safe-buffer module to stay backwards compatible with node < v4. For the full story see here
I'd also be totally open to switching out the safe-buffer shim with a ponyfill.
The deprecated method of buffer creation concerns the oracle dialect. I tried to run the tests but failed to do so. If someone who can run the
DB='oracle' npm testcommand would try it I'd be very grateful.To be clear, this doesn't fix #1763. That issue is with knex' dependencies still. In particular node-postgres. However now that
new Buffer(size)has also been deprecated this should be merged.