Allow passing version of connected db in configuration file #1993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# The first commit's message is: Allow passing config.version variable to knex instead of parsing the DB version from string returned form DB server. This makes it possible to connect custom databases which are compatible with an official database of certain version. # The 2nd commit message will be skipped: # Update checkVersion # # To use `const` instead of `let` to fix lint error # The 3rd commit message will be skipped: # Revert "Update checkVersion" # # This reverts commit 248907d.
…DB version from string returned form DB server. This makes it possible to connect custom databases which are compatible with an official database of certain version.
This was referenced Mar 26, 2017
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased and cleaned up #1959 to see if it passes now.