Fix adding multiple columns in Oracle #2115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izri16
force-pushed
the
fix-adding-more-cols-oracle
branch
2 times, most recently
from
60d9c5c
to
8aa8970
Compare
izri16
changed the title
|
Could you also enable this line https://github.com/tgriesser/knex/pull/1914/files#diff-b91681a6009d38db70d89305944b4318R332 so that feature is tested with integration test too? |
* Fix incorrent unit tests to reflect current changes
izri16
force-pushed
the
fix-adding-more-cols-oracle
branch
from
8aa8970
to
f1bc45c
Compare
|
Done. |
|
awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #1916
I also fixed incorrect unit tests to reflect current changes.