Fixes issue where mssql incorrectly strips off apostrophe characters from identifiers #4077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@smorey2 [mssql]
We have a column, "NA'ME" that we use for testing to ensure ids are escaped properly. After upgrading from knex 0.15.2 to 0.21.6, our tests started to fail with an error that the column "NAME" does not exist. I tracked it down to the mssql dialect is incorrectly stripping out the apostrophe (') character. This change seems to have included a superfluous apostrophe. The code should wrap identifiers in [brackets].
If all is good, please kindly tag the PR as "hacktoberfest-accepted" for credit towards hacktoberfest.