New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for altering columns to SQLite #4322
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kibertoad
reviewed
Feb 26, 2021
kibertoad
reviewed
Feb 26, 2021
kibertoad
reviewed
Feb 26, 2021
kibertoad
reviewed
Feb 26, 2021
kibertoad
reviewed
Feb 26, 2021
nickrum
force-pushed
the
sqlite-alter-column-feature
branch
from
February 26, 2021 19:42
d345ac1
to
8c8c336
Compare
Unit tests seem to be failing now. |
Very strange... This seems to be caused by requiring |
@nickrum I would imagine a circular dependency happening. |
kibertoad
reviewed
Feb 26, 2021
nickrum
force-pushed
the
sqlite-alter-column-feature
branch
from
February 26, 2021 20:08
8c8c336
to
dec2005
Compare
@kibertoad Good catch, |
nickrum
force-pushed
the
sqlite-alter-column-feature
branch
from
February 26, 2021 20:28
dec2005
to
0cdb4aa
Compare
kibertoad
approved these changes
Feb 26, 2021
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The approach I took to parse
CREATE INDEX
statements using regexes was unfortunately not flexible and robust enough to properly parseCREATE TABLE
statements. I replaced it with a tokenizer and parser combinators. The grammar is based on the SQLite documentation.Any idea where the
formatDefault()
function would fit? It is currently directly inside theColumnCompiler
class which doesn't feel right.