-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add inherits to postgres. Updated dialect-specific methods. #601
Conversation
Can you explain the MyISAM related stuff? |
The engine stuff was added long ago (0f38f04) but I couldn't find a unit test around it. I added two tests for "engine": 1. Make sure MySql uses "engine". 2. Make sure PostgreSQL ignores "engine". Adding "inherits" to PostgreSQL was similar to "engine", so I followed the same principles. |
+1 |
Any chance this is going to be added? I'd be happy to make any changes that are needed to get issues resolved, if no one else can/wants to. |
2b696c9
to
20e721b
Compare
@MrBucket I've updated to resolve conflicts. |
20e721b
to
c4a5790
Compare
@joeframbach Thank you for updating. |
@MrBucket @joeframbach Hadn't seen this one before. I'll merge this if we can remove the |
I started going through old pull requests and get them merged if possible or close otherwise if they are not going to be finished. @joeframbach Nice feature! If you rebase this one more time to top of master, I'll make sure this gets merged. |
@MrBucket If you still like to finish this, rebasing this to top of master and removing code from I'll leave this open for one more month and if still pending, close the PR and move this to issues to wait for finishing. |
6dcd9be
to
fcb92a7
Compare
fcb92a7
to
cf8222d
Compare
I've updated but Travis seems confused. Gonna close and re-open to kick off Travis. |
Add inherits to postgres. Updated dialect-specific methods.
@joeframbach Awesome, thanks! |
Allow postgres tables to inherit. http://www.postgresql.org/docs/9.1/static/ddl-inherit.html