Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
no way to disable transactions in knex 0.8.0+ migrations #834
Problem with that is that there are some databases and some commands that just can not be run under an active database transaction. For example, running a
This is also related to a problem of knex reporting such failures by just logging an end-user warning message and not reporting it on as a regular promise rejection, but I'll log that as a separate issue.
I have not yet tested whether and how I can manually stop and restart
Ah wow, that's interesting - didn't realize you couldn't do that. Did a little digging and this seems to be how rails fixed it - via disabling ddl transactions on a per-migration basis
I'll look to get something in there to turn this off... would you prefer a flag to have them disabled for all migrations or one which disables on a per-file basis?
Well, for easy backward compatibility, it would definitely be good to be able to disable them all together.
Allowing disabling them for specific files seems like a logical next step, but is not really something I need at this moment so haven't given much thought to how the interface for that would function.