Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump mysql dependency to 2.0.0-rc2 #126

Closed
wants to merge 1 commit into from
Closed

Conversation

floatdrop
Copy link

Mysql dependency is bit old.

@floatdrop floatdrop closed this Dec 9, 2013
@bendrucker
Copy link
Member

Hey @floatdrop -- not sure why the migration tests are failing on 0.1 (I wrote the test that's failing). It's failing across mysql, pg, and sqlite so it's definitely not due to your change. The migrate.latest method resolves with an array of the migrations that have been run in the order that they were run. It does appear that both are running (previous test confirms) but not in order. Obviously that's a critical issue that would totally break a live migrations implementation.

I'll do a little investigating and see if I can figure out what's going on.

@floatdrop
Copy link
Author

Glad that pr help you some how. I saw, that mysql was in developer deps and decide to close it.

@bendrucker
Copy link
Member

It's there for running tests and it definitely couldn't hurt to have the most current version

@bendrucker
Copy link
Member

Moving this into a new issue. Not sure what's going on here.

JakobJoonas pushed a commit to JakobJoonas/knex that referenced this pull request Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants