Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

include scripts in npm package #1737

Merged
merged 1 commit into from Oct 12, 2016
Merged

include scripts in npm package #1737

merged 1 commit into from Oct 12, 2016

Conversation

calvinmetcalf
Copy link
Contributor

fix for #1736

@calvinmetcalf
Copy link
Contributor Author

better longer term solution might be to remove the postinstall

@WebReflection
Copy link

Please "save" 0.12.x with this change and flag as deprecated v 0.12.4, thank you!

npm deprecate knex@0.12.4 "Fails the postinstall due missing ./script folder"

@tgriesser tgriesser merged commit 6500b2f into knex:master Oct 12, 2016
@tgriesser
Copy link
Member

Whoops, my mistake

tgriesser pushed a commit that referenced this pull request Oct 12, 2016
@calvinmetcalf @tgriesser
include scripts in npm package (#1737)
3871aa4
tgriesser added a commit that referenced this pull request Oct 12, 2016
@tgriesser
Merge branch '0.12.x'
0949ed3 
* 0.12.x:
  release 0.12.5
  Update changelog
  include scripts in npm package (#1737)
rslabbert pushed a commit to rslabbert/knex that referenced this pull request Nov 9, 2016
@calvinmetcalf
include scripts in npm package (knex#1737)
bf1b62a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@calvinmetcalf @WebReflection @tgriesser