Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: countDistinct with multiple columns #2449

Merged
merged 11 commits into from Mar 12, 2018
Merged

feat: countDistinct with multiple columns #2449

merged 11 commits into from Mar 12, 2018

Commits on Jan 31, 2018

  1. test(QueryBuilder): add test for countDistinct with multiple columns

    @joelmukuthu
    joelmukuthu committed Jan 31, 2018
    Copy the full SHA
    3c1236e View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2018

  1. test: add integration test for countDistinct with multiple columns

    Joel Mukuthu committed Feb 5, 2018
    Copy the full SHA
    c0541a6 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2018

  1. feat(QueryBuilder): support multiple columns for countDistinct

    @joelmukuthu
    joelmukuthu committed Feb 16, 2018
    Copy the full SHA
    8d86c92 View commit details
    Browse the repository at this point in the history

  2. feat(QueryBuilder): support object alias notation for aggregate methods 

    i.e. `count`, `countDistinct`, `max`, `min`, `avg`, `avgDistinct`, `sum`, `sumDistinct`
    @joelmukuthu
    joelmukuthu committed Feb 16, 2018
    Copy the full SHA
    e264765 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feature/count-distinct-multiple

    @joelmukuthu
    joelmukuthu committed Feb 16, 2018
    Copy the full SHA
    2baff54 View commit details
    Browse the repository at this point in the history

  4. test: fix integration tests for countDistinct

    @joelmukuthu
    joelmukuthu committed Feb 16, 2018
    Copy the full SHA
    31dea33 View commit details
    Browse the repository at this point in the history

  5. fix(QueryBuilder): fix countDistinct formatting with multiple columns

    @joelmukuthu
    joelmukuthu committed Feb 16, 2018
    Copy the full SHA
    0d42905 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2018

  1. refactor(QueryBuilder): add _aggregate from helpers

    @joelmukuthu
    joelmukuthu committed Feb 17, 2018
    Copy the full SHA
    a3a5255 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2018

  1. fix(QueryCompiler): only use parens for distinct with postgres

    @joelmukuthu
    joelmukuthu committed Feb 23, 2018
    Copy the full SHA
    0baa6d2 View commit details
    Browse the repository at this point in the history

  2. test(QueryBuilder): remove unsupported tests 

    for count with multiple distinct columns in databases where this is
not supported
    @joelmukuthu
    joelmukuthu committed Feb 23, 2018
    Copy the full SHA
    f471d35 View commit details
    Browse the repository at this point in the history

  3. refactor(QueryBuilder): improve readability

    @joelmukuthu
    joelmukuthu committed Feb 23, 2018
    Copy the full SHA
    06b383c View commit details
    Browse the repository at this point in the history