Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix execution of Oracle tests on Node 11 #2920

Merged
merged 1 commit into from Nov 21, 2018
Merged

Fix execution of Oracle tests on Node 11 #2920

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions scripts/oracle-tests-Dockerfile
View file
Open in desktop
Expand Up @@ -28,6 +28,7 @@ RUN curl -o- https://raw.githubusercontent.com/creationix/nvm/v0.33.11/install.s
RUN . $HOME/.nvm/nvm.sh && nvm install 6
RUN . $HOME/.nvm/nvm.sh && nvm install 8
RUN . $HOME/.nvm/nvm.sh && nvm install 10
RUN . $HOME/.nvm/nvm.sh && nvm install 11

RUN echo 'module.exports = {\
oracledb: {\
Expand All @@ -39,7 +40,7 @@ RUN echo 'module.exports = {\
}' > /oracle-config.js

ENV ORACLE_HOME /u01/app/oracle/product/11.2.0/xe
ENV ORACLE_SID XE
ENV ORACLE_SID XE
ENV OCI_LIB_DIR /u01/app/oracle/product/11.2.0/xe/lib
ENV LD_LIBRARY_PATH /u01/app/oracle/product/11.2.0/xe/lib
ENV KNEX_TEST /oracle-config.js
Expand All @@ -55,4 +56,4 @@ CMD /usr/sbin/startup.sh && \
npm install && \
npm install oracledb && \
npm run build && \
npm run plaintest
npm run plaintest