New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Implement "skipLocked()" and "noWait()" #2961
Merged
Merged
Changes from 18 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
150fb08
Implement "skip locked" and "nowait" for Postgres dialect
ricmzn b9dd2c6
Fix error with duplicate skipLocked or noWait call
ricmzn 21775f9
Fix noWait test swallowing errors on non-postgres databases
ricmzn 0f13016
Implement skipLocked and noWait for mysql-based clients
ricmzn d73663a
Disable skipLocked test on MySQL
ricmzn dbac68e
Restrict noWait test to supported databases
ricmzn 71fd14b
Update knex.d.ts with skipLocked and noWait
ricmzn de3b4cc
Adjust noWait test for MySQL 8.0
ricmzn 94de977
Disable noWait test on MySQL
ricmzn 7db84fa
Increase query builder test coverage for MySQL
ricmzn e49c4b7
Remove MySQL support for skipLocked() and noWait()
ricmzn f32488f
Add errors for databases that don't support skipLocked() and noWait()
ricmzn 6b44e37
Merge remote-tracking branch 'upstream/master' into feature/skip-locked
ricmzn dcaff9e
Update test comments
ricmzn 18cccab
Restore MySQL tests for #2961
ricmzn e9b152d
Simplify query builder checks on first(), noWait() and skipLocked()
ricmzn 2a92c9d
Add some failing tests for PR #2961
ricmzn 6eb290a
Replace broken test on MySQL with an extra test for #2961
ricmzn b22cd7b
Adjust the #2961 tests to use async/await
ricmzn c0b1cd4
Move some magic query builder values into constants
ricmzn File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably these could be constants?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, but I can't find a good place for query builder constants. Is it worth it to create one now, or would this be more fitting for a future refactor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't get much refactoring PRs, as people have no good reason for submitting these :D. Would be awesome if you created something for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll try
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made it a separate module in c0b1cd4, how do you like it?