Fix typescript issue described by #3116 #3269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shaungreen Unfortunately, this change would introduce build time dependency on mssql types even for those who don't use mssql, so I would prefer to avoid that. Could you sync included type instead? |
|
Will do.
…On Sat, 8 Jun. 2019, 7:29 pm Igor Savin, ***@***.***> wrote:
@shaungreen <https://github.com/shaungreen> Unfortunately, this change
would introduce build time dependency on mssql types even for those who
don't use mssql, so I would prefer to avoid that. Could you sync included
type instead?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3269>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AG34K7JPGDBBTOIXVRQQVTLPZN3XFANCNFSM4HWEGREA>
.
|
|
Done. See #3269
…On Sat, 8 Jun 2019 at 20:20, Shaun Green ***@***.***> wrote:
Will do.
On Sat, 8 Jun. 2019, 7:29 pm Igor Savin, ***@***.***> wrote:
> @shaungreen <https://github.com/shaungreen> Unfortunately, this change
> would introduce build time dependency on mssql types even for those who
> don't use mssql, so I would prefer to avoid that. Could you sync included
> type instead?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <#3269>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AG34K7JPGDBBTOIXVRQQVTLPZN3XFANCNFSM4HWEGREA>
> .
>
--
Kind Regards,
Shaun Green
LinkedIn Profile: http://au.linkedin.com/in/lookmeup
|
kibertoad
approved these changes
Jun 10, 2019
|
Thanks! |
|
Released in 0.18.0-next1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(not sure how to test with my setup)