Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typescript issue described by #3116 #3269

Merged
merged 3 commits into from Jun 10, 2019

Conversation

Projects
None yet
2 participants
@shaungreen
Copy link
Contributor

commented Jun 8, 2019

(not sure how to test with my setup)

shaungreen added some commits Jun 8, 2019

@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented Jun 8, 2019

@shaungreen Unfortunately, this change would introduce build time dependency on mssql types even for those who don't use mssql, so I would prefer to avoid that. Could you sync included type instead?

@shaungreen

This comment has been minimized.

Copy link
Contributor Author

commented Jun 8, 2019

@shaungreen

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2019

@kibertoad kibertoad merged commit 87d4c0b into tgriesser:master Jun 10, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 87.853%
Details
@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented Jun 10, 2019

Thanks!

@kibertoad

This comment has been minimized.

Copy link
Collaborator

commented Jun 17, 2019

Released in 0.18.0-next1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.