Backport typings related changes to 0.17 #3270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use number instead of number | string for return type of count Closes #3247 * Use an alias instead of interface for DeferredKeySelection This prevents typescript from complaining when it has to be used in an exported signature without us having to expose internal type as public Closes #3259 * Make count result type overridable * Disable interface-over-type-literal rule
|
@lorefnon Ooooh, this is amazing, thank you! Shall I release next version as soon as this is merged, or you prefer to get documentation ready first? |
|
Thanks :) The ts docs are also pretty much done from my end. If you have any suggestions there I can take care of them. |
|
@lorefnon Just a couple of minor spelling things. Feel free to merge it when you want :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #3249 (comment)