Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange behavior if "Open table controls toolbar" hotkey is pressed when it's already showing #19

Closed
luckman212 opened this issue Nov 5, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@luckman212
Copy link

Describe the bug
If you activate the "Open table controls toolbar" hotkey, and then repeat the keyboard shortcut- instead of doing nothing or toggling off, a dim row of --------------s is inserted above the toolbar area. This repeats as many times as you press the key, until you switch to another note, or toggle edit/preview mode. The area is non-clickable.

To Reproduce

  1. Make table
  2. click into table
  3. hit hotkey (⌘D in my case - I have customized it, but also tested with the default ⇧⌘D)
  4. toolbar opens
  5. press hotkey again, and keep pressing it

Expected behavior
Toolbar should either do nothing, or toggle closed if hotkey is activated when already showing.

Desktop (please complete the following information):

  • OS: macOS 10.15.7
  • Obsidian Version: v0.9.11
  • Advanced Tables Version: 0.5.2

Screen recording (open larger)
tables

@luckman212 luckman212 added bug Something isn't working needs-review A newly created issue that has not yet been processed labels Nov 5, 2020
@dirkschut
Copy link

Confirmed on this setup:
OS: Windows 10 (1909)
Obsidian: v0.9.10
AT: v0.5.2

The bug also occurs when pressing the Advanced Tables Toolbar button in the sidebar.

@dirkschut
Copy link

Pressing the close toolbar button does NOT remove these weird artifacts

@tgrosinger tgrosinger removed the needs-review A newly created issue that has not yet been processed label Nov 6, 2020
@tgrosinger
Copy link
Owner

Thank you both for the issue report. Should be solved in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants