Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cells with emoji are not formatted properly #33

Closed
DutchPete opened this issue Nov 29, 2020 · 6 comments
Closed

Cells with emoji are not formatted properly #33

DutchPete opened this issue Nov 29, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@DutchPete
Copy link

Describe the bug
A clear and concise description of what the bug is.

*Even after formatting, not everything is formatted.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Make a table, fill the cells, and do a format.
This bug occurs both with "format at cursor" and "format all tables".

Expected behavior
A clear and concise description of what you expected to happen.

All pipes to line up

Screenshots
If applicable, add screenshots to help explain your problem.

table1

Desktop (please complete the following information):

  • OS: [e.g. iOS] macOSX
  • Obsidian Version: [e.g. v0.9.10] (Settings → About → Current Version) 0.9.19
  • Advanced Tables Version: [e.g. 0.4.0] (Settings → Third-party plugin → Browse → Advanced Tables → currently installed) 0.7.0

Additional context
Add any other context about the problem here.

@DutchPete DutchPete added bug Something isn't working needs-review A newly created issue that has not yet been processed labels Nov 29, 2020
@tgrosinger tgrosinger changed the title Format does not format everything Cells with emoji are not formatted properly Nov 30, 2020
@tgrosinger tgrosinger removed the needs-review A newly created issue that has not yet been processed label Nov 30, 2020
@tgrosinger
Copy link
Owner

@DutchPete, thanks for the bug report. I think this is because emoji often consist of two characters which are rendered as a single character. Making these work in monospace fonts might be tricky... but I will give it a shot.

@DutchPete
Copy link
Author

@tgrosinger

… but I will give it a shot.

Tony, any chance to have a look at that?

@tgrosinger
Copy link
Owner

Oh, no I have not had a chance to yet. Thanks for the reminder. I will make an effort to look into it this week.

@tgrosinger
Copy link
Owner

@DutchPete, I'm having trouble reproducing the problem you are experiencing. For me the columns are not quite perfectly aligned with the emoji, but it's not like the example you showed me where they are completely misaligned.

Screen Shot 2020-12-06 at 3 10 52 PM

Can you please copy and paste your whole example table into this ticket (surround in a code block). Please also let me know if you have changed the font via either a css snippet, or in the Advanced Tables Plugin Setting (see image below).

Screen Shot 2020-12-06 at 3 13 26 PM

@DutchPete
Copy link
Author

DutchPete commented Dec 7, 2020

@tgrosinger : your last question (monospace) triggered me to check. When I 1st installed your plug-in we discussed the font and you made me understand it would have to be a monospace font, so I looked for one that also looks nice in Preview - remember I try to emulate WYSIWYG.

So I found and installed Inconsolata. But somehow that was deleted somewhere along the line without me realizing it. Today I checked, saw the box was empty so monospace was back to default. I put Inconsolata back, and ……… bingo, problem solved !! It is almost perfect ! And that font is a lot nicer than the default font.

Many thanks for your help, and apologies for having disturbed you 😳

@tgrosinger
Copy link
Owner

Oh good, glad it's sorted out. No worries 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants