Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "timezone" mdio "created" date #114

Closed
blasscoc opened this issue Oct 24, 2022 · 2 comments · Fixed by #115
Closed

Add "timezone" mdio "created" date #114

blasscoc opened this issue Oct 24, 2022 · 2 comments · Fixed by #115
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@blasscoc
Copy link

mdio data has a "create" field in it's "zattrs" file.

The propose feature would add time zone information to this datetime in some canonical way.

In a scenario where timezone information is unavailable; the meta data should record that it does not have that information; and not default to something like UTC.

@tasansal
Copy link
Collaborator

Good point. I think one clean way to standardize it would be to always save it as UTC and define it as a part of the standard to avoid time zone confusion. Then it's up to the client library to decide what to do with that information.

@tasansal tasansal added enhancement New feature or request good first issue Good for newcomers labels Oct 24, 2022
@blasscoc
Copy link
Author

@tasansal thanks for the quick reply. Yes; since there likely isn't a large backlog of mdio data yet, having that requirement would save some trouble in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants