Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeline does not support predict_in_sample #196

Closed
ihadanny opened this issue Oct 27, 2019 · 2 comments
Closed

pipeline does not support predict_in_sample #196

ihadanny opened this issue Oct 27, 2019 · 2 comments
Labels
feature request A tag for feature requests

Comments

@ihadanny
Copy link

created a pipeline, now I would like to visualize the goodness of my fit.
would be neat to simply write: pipe.predict_in_sample().

I also tried pipe.steps[2][1].predict_in_sample() but got: ValueError: When an ARIMA is fit with an exogenous array, it must also be provided one for predicting or updating observations.

@ihadanny ihadanny added the feature request A tag for feature requests label Oct 27, 2019
@tgsmith61591
Copy link
Member

This is a really great feature request, thanks. Given your other request on #195 I'm guessing you're using the pipeline to create your Fourier features, which you don't have in an exogenous array outside of the pipeline, which is why calling the ARIMA object directly won't work.

Let me work something up

@tgsmith61591
Copy link
Member

Merged in #198

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request A tag for feature requests
Projects
None yet
Development

No branches or pull requests

2 participants