Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log out messages being randomly shown to players #664

Closed
ghost opened this issue May 28, 2013 · 15 comments
Closed

Log out messages being randomly shown to players #664

ghost opened this issue May 28, 2013 · 15 comments
Labels
Bug Correct Functionality BYOND Issue We are trapped in the belly of this horrible machine Higgs-Bugson We know it happens, we just don't know how

Comments

@ghost
Copy link

ghost commented May 28, 2013

Revision that this bug was encountered on:

Badgerstation doesn't list the revision properly.

Server which you encountered the bug on:

Badgerstation

Problem Description:

Sometimes, when a random player logs out, everyone will get shown a log-out message containing their character name, ckey and the time they logged out.

It's not really an issue, but some people like to keep their character name and ckey separate.

Steps to reproduce the problem:

I don't know how you would reproduce it. Get onto a busy server and hope one appears?

@Petethegoat
Copy link
Contributor

This has been happening forever. Dunno why, though.
I remember looking into it literally years ago, and I couldn't figure out why it was happening. If you get me a sample of the logout text I can look into it again.

@ghost
Copy link
Author

ghost commented May 28, 2013

I tried to get it, but I lost it in the chat box. It was like 80 players so the chat was scrolling fast. Next time I see one I'll save it.

@ghost
Copy link
Author

ghost commented May 29, 2013

[14:48:04]ACCESS: Logout: Merik _Shadow[DC]/(Edward Freeman)

GOT YOU YA CUNT

Sibyl1, 46 players

@caelaislinn
Copy link
Contributor

I've got a hunch that it's unlikely to be located in the client code, otherwise we would have found and fixed it ages ago.

@KazeEspada
Copy link
Contributor

what if its in the byond to IRC code?

@Petethegoat
Copy link
Contributor

It predates the IRC integration.

@Petethegoat
Copy link
Contributor

The offending line is line 3 of code/modules/mob/logout.dm, which calls log_access("Logout: [key_name(src)]")
Presumably it's a problem with log_access (ha ha gl)

@Petethegoat
Copy link
Contributor

And log_access is
/proc/log_access(text)
if (config.log_access)
diary << "[[time_stamp()]]ACCESS: [text]"

so blame byond?? i dunno

@caelaislinn
Copy link
Contributor

wot

@ghost
Copy link
Author

ghost commented Jun 1, 2013

alt

I'm not an admin.

@Iamgoofball
Copy link
Contributor

@Tobba told me to post this link:

http://www.byond.com/forum/?post=1326123

@phil235 phil235 added the BYOND Issue We are trapped in the belly of this horrible machine label Apr 25, 2015
@tkdrg
Copy link
Contributor

tkdrg commented Jan 23, 2016

I haven't seen this happen in a few months. I wonder if it's still around.

@duncathan
Copy link
Contributor

This is not our bug ;_;7

LemonInTheDark pushed a commit to LemonInTheDark/tgstation that referenced this issue Dec 12, 2021
* Winter coat allowed item fixes (tgstation#61450)

Sometime ago I cleaned a slice of the winter coats to cut on copy pasta in their allowed list and important items being missed there but I misunderstood how the global list of allowed security items work, which ended up with the global list overwriting my base list.
So this fix that, also thanks Athath for bullying me about this issue a few months ago before I went on coding hiatus...

Also since I was here I decided to fix the allowed list for the janitor winter coat, it had some odd items without a worn_icon so we had the annoying bugged sprites with it.

* Winter coat allowed item fixes

Co-authored-by: GuillaumePrata <55374212+GuillaumePrata@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Correct Functionality BYOND Issue We are trapped in the belly of this horrible machine Higgs-Bugson We know it happens, we just don't know how
Projects
None yet
Development

No branches or pull requests

8 participants
@Petethegoat @caelaislinn @duncathan @phil235 @KazeEspada @Iamgoofball @tkdrg and others