Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a Join Queue if the server exceeds its hard population cap [Ready] #10566

Merged
merged 2 commits into from Jul 23, 2015

Conversation

Ikarrus
Copy link
Contributor

@Ikarrus Ikarrus commented Jul 12, 2015

Players can join a queue that will notify them with a message and sound when a slot becomes available. First come first serve.

It even tells you how many other players are ahead of you in the queue.

Players have approximately 20 seconds to join after the notification. Failure to join in that window removes them from the queue, to remove AFKers.

Players can join a queue that will notify them with a message and sound when a slot becomes available. First come first serve.

Players have approximately 20 seconds to join after the notification. Failure to join in that window removes them from the queue, to remove AFKers.

I haven't tested the code yet but it's basically done.
@Iamgoofball
Copy link
Contributor

can I buy VIP access to bypass the queue

when will we have Premium accounts

@Ikarrus Ikarrus changed the title Adds a Join Queue if the server exceeds its hard population cap Adds a Join Queue if the server exceeds its hard population cap [WIP] Jul 12, 2015
@WJohn
Copy link
Contributor

WJohn commented Jul 12, 2015

I have a feeling this will never even be required given that it's almost impossible to have 70 living players in the game at any one time, but I guess it's better to have it.

@duncathan
Copy link
Contributor

I had this issue like, last week. It's summer, man.

@CosmicScientist
Copy link
Contributor

@WJohn in this thread: https://tgstation13.org/phpBB/viewtopic.php?f=10&t=4120

Scroll down midway to find MSO claiming:
"Currently, there are 3 caps:

Soft cap at 50. This is what I set the banners to. You can join, it just nicely requests you join another server.

Hard cap at 65. This prevents joining the game, but you can observe.

Extreme cap at 70. This prevents connecting to the server. I put this in place after I watched the server buckle at 95 players. while basil had almost none. basil then got 10 new players. It was nice."

I don't know about round start but afterwards you get 65 living players maximum.

if(!queued_players.len || !config.hard_popcap)
return

queue_delay ++
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

queue_delay++ not queue_delay ++

@Ikarrus Ikarrus changed the title Adds a Join Queue if the server exceeds its hard population cap [WIP] Adds a Join Queue if the server exceeds its hard population cap [Ready] Jul 12, 2015
Jordie0608 added a commit that referenced this pull request Jul 23, 2015
Adds a Join Queue if the server exceeds its hard population cap [Ready]
@Jordie0608 Jordie0608 merged commit da7f758 into tgstation:master Jul 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants