Makes restart votes not restart the server if admins are online #11155
Conversation
| @@ -116,7 +116,18 @@ var/datum/subsystem/vote/SSvote | |||
| else | |||
| master_mode = . | |||
| if(restart) | |||
| world.Reboot("Restart vote successful.", "end_error", "restart vote") | |||
| if(!admins.len) | |||
There was a problem hiding this comment.
this means the restart vote won't work if there aren't admins.
|
actually 👍 yes |
|
Might as well stop the vote from happening together. If admins want democracy they can make their own vote. |
|
If enough people are dead and or want to restart the round, letting the vote pass will reflect without instantly ending the round and admins can react in turn to this information in other ways. |
|
If the restart vote actually has enough people saying restart to pass, it's probably passing for a reason, because even at the most butthurt it's usually only 25-30% of the people on saying yes. |
|
if enough people are dead and want to restart the round, you'll be able to tell by them chanting "SEND DEATHSQUAD". |
|
Because admins cancel them everytime, EVERYTIME. This just makes the solution concrete. |
| var/active_admins | ||
| active_admins = total_admins - afk_admins | ||
| if(active_admins <= 0) | ||
| world.Reboot("Restart vote successful.", "end_error", "restart vote") |
There was a problem hiding this comment.
This needs an else, to let the users know that it is waiting on the admins.
As well as let the admins know that they need to decide to restart.
This way admins can allow a restart vote, and if it passes, decide to restart the server, AND users know this is going on.
Improve the check for active admins
| return | ||
| var/total_admins | ||
| var/afk_admins | ||
| for(var/client/C in admins) |
There was a problem hiding this comment.
He copied this from ahelp code, where it calculates afk admins for reporting.
It will only count admins who can actually restart the server. It will stop searching for admins once it finds one. It will let the users and admins know that the restart vote will not automatically restart the server because of the active admins.
improvements to vote restart when admins are on
|
while we're at it, the reasoning for this is because i recently had a round on sybil where there were no admins for an extended period of time, and the nuke ops had killed literally everyone but a lawyer and somebody meta'd their shuttle and spaced the nuke, meaning the round was effectively a stalemate. a restart vote came around (that had valid reasoning and by all means should have passed), but it lost by like 3 votes because so many people just go AFK and wait for the round to end. if this is out of the scope of this PR i'll post this in the ideas forum or something |
|
Do not votes are counted as Nos because it's assumed that they are content with the round but didnt choose to vote. I think anyway.... A better solution would be for restart votes to ignore AFKs in their system completely. |
|
but the thing is, in the round i mentioned that stalemated, a bunch of people got bored in deadchat and just alt+tabbed, meaning they would have voted yes but didn't because they weren't even aware of the vote
this sounds good in theory, but you and i both know a bunch of joke restart votes will pass because of this |
|
The restart vote is an emergency system only, at least that is how I see it. As previously stated, it is not for "i ded plz restart", it is for when the round has bugged out or reached an unreasonable state. It is an admin's duty to ensure that rounds to do not reach such extremes, therefore this system should only exist to allow players to fix the server themselves in the absence of admins. |
|
That's what this PR does |
|
thats a config option pk |
|
Seems like a pointless change given restart votes fail 99% of the time anyway I think I've seen four go through in three years, all due to bugs making the game unplayable (i.e. never due to "i ded restart", and due to admins not being quick enough to restart the game themselves despite it being broken) It'd be interesting to know the situation you were in when you found yourself overrun by players wanting to restart the game, when you yourself didn't. |
|
lmao restart votes never pass anyway, whats the point of this in the first place |
|
I saw one pass once. |
|
They pass a lot on basil. I once got a restart vote called when I dunked all 6 people on the station, set the singulo free, then blew myself up with C4 |
|
Yeah, they should pass in that situation. On 12 August 2015 at 23:54, Dorsisdwarf notifications@github.com wrote:
|
|
That is a case of the system working properly. I presume that admins are rare on Basil, so they players there must govern themselves. This change would not affect them much. When they have admins online, it then becomes that admin's job to handle things such as complete murderboner and the like. Also, there used to be a check that restarted the round if everyone died. What happened to that? |
|
That check made testing locally a pain On Thu, Aug 13, 2015 at 1:04 AM, GunHog notifications@github.com wrote:
|
WJohn
added
the
Administration
|
Votes almost never pass. When they do, it's for a good reason. Why change this? Pretty sure admins can cancel votes, if for some reason having over 50% of people actively saying 'this round is utterly fucked' doesn't matter to them. |
|
Because that's not the function of restart votes. The votes exists to solve a code problem or in a situation where the server can't restart, not just because 50% of the players are dead and are salty in deadchat. If admins are online, the vote would get cancelled and an admin would stir in IC things to end the round instead of just instantly making it end. When admins are not online, that option is viable so the votes actually work without them. I stated this like 3 times now |
|
Stop saying votes almost never pass. Votes never pass on Sybil. They pass on Basil fairly frequently. This is a good change and the only way to improve further would be to have "Did not vote" stop counting as "No". If they're content with the round, then they should vote "no". You shouldn't get butthurt if it passes when you didn't vote in the first place. |
This is a config option. |
|
@Niknakflak if over 50% of players are 'salty in dead chat' to the point they all actually vote for a restart, tha means it's more then just 'i ded pls restart' ie: mcfaggot killing the entire crew an just recalling endlessly to try hunt down the last guy while 30 people sit with their dicks in their collective hands for an hour. Or you know, the server going to shit. |
|
You miss the point. That reason doesn't even apply if admins are on as they can solve that issue of mcfaggot recalling endlessly through IC means or deleting the console therefore ending the round organically and not fucking any antags round up by ending it abruptly. If no admin is online, that can't be done therefore the votes will be allowed to work if no admins are online because the above solution can't be used. |
|
I don't think this is done properly, the admins should probably get a query if they accept the restart vote BEFORE the vote is done and the entire server is informed |
|
That's not the point of this PR though, that's not what needs to happen. This isn't about an admin using the vote to restart. |
|
WHAT I WANT: |
|
we dont' always get what want |
|
we get the world we deserve.......................... On 15 August 2015 at 12:14, Orange Borg notifications@github.com wrote:
|
|
No, that's not that purpose of restart votes. They aren't supposed to be used that way.
If admins are offline.
What you want Aran does nothing |
|
Aran. What happens if the status of admins changes while the vote goes on? HMMM??????? The check should be after, not before. And there is no need to commit to a restart vote, the admin may want to use it purely to gauge server interest in restarting, then use that info to decide how many fun buttons to hit to help the round end. Here, let me try speaking your language: |
Makes restart votes not restart the server if admins are online
|
really gay On 19 August 2015 at 21:07, Jordie notifications@github.com wrote:
|
|
wow it's fucking nothing to get upset about jesus |
|
calling it really gay really isn't getting upset On Thu, Aug 20, 2015 at 9:09 AM, Orange Borg notifications@github.com
|
Restart votes exist to restart the server if something goes horribly wrong and it needs to be restarted, not because "I ded, restart"
If admins are on, they can already restart the server with verbs if something goes horribly wrong and the server needs to be toasted. Therefore, the restart vote will pass if they are online but do nothing.
It also checks if the admins are afk so votes will still go through if you have a bunch of afk admins