Adds large cardboard boxes #11706

Incoming5643 · 2015-09-10T23:35:47Z

Adds large cardboard boxes to the game, constructable from four sheets of cardboard. Roughly 20% of all generic closets on the map will now instead spawn as these.

Cardboard boxes are closets that:

Can only carry a single person
Are easy to destroy
Are flammable
Can't be welded shut

They can also can be used for more "tactical" purposes, at the same speed as walking.

Takes the opportunity to remove some object unfriendly coding.

…s of cardboard. Cardboard boxes are closets that: *Can only carry a single person *Are easy to destroy *Are flammable *Can't be welded shut They can also can be used for more "tactical" purposes, at the same speed as walking. Takes the opportunity to remove some object unfriendly coding. If this is accepted they'll be a pull a little later to replace a few closets on the maps with boxes (or maybe code to have generic closets on the map to occasionally spawn as boxes instead).

Incoming5643 · 2015-09-10T23:41:32Z

There's no sprites yet 🙈

Iamgoofball · 2015-09-10T23:44:50Z

👍

Nitrousoxide · 2015-09-10T23:49:58Z

Please make them look like the cardboard cutout of a lizard maid if you run with them on.

PKPenguin321 · 2015-09-10T23:50:31Z

godlike 👍

duncathan · 2015-09-10T23:57:35Z

!

harmonyn · 2015-09-11T00:03:40Z

if runtime is near a large cardboard box she should run inside it

Fox-McCloud · 2015-09-11T00:30:04Z

They can also can be used for more "tactical" purposes, at the same speed as walking.

Ha..

Aloraydrel · 2015-09-11T00:31:19Z

!

Kromgar · 2015-09-11T00:50:24Z

Now have cardboard boxes in maint and suddenly shadowlings hiding in cardboard boxes is new meta

ike709 · 2015-09-11T01:22:22Z

Make it so you can attach a poster to it when standing up with it and walking around.

👍

ghost · 2015-09-11T11:30:15Z

Done https://www.dropbox.com/s/wjkvi28quub4kip/MGS.dmi?dl=0

peoplearestrange · 2015-09-11T12:10:10Z

👍 Nienhaus comes up trumps with a sprite again.

Dis gun be good.

Incoming5643 · 2015-09-11T15:12:13Z

Excellent Nienhaus, age hasn't slowed you down one bit

Fox-McCloud · 2015-09-11T19:04:23Z

There needs to be a subtype of this box that has a "!" sound play when you open it.

ghost · 2015-09-11T21:14:33Z

@Incoming5643 Later tonight I'm going to improve that. I spent like 10 minutes on it this morning when I woke up.

… sprite(s) coming) Every roundstart generic locker now has a 20% chance of instead being a cardboard box (this is not the same thing as "20% of all lockers are now boxes" but it's a rough approximation). As an easter egg, if you open a box containing a person everyone in sight will get a ! alert. This effect can only be triggered if someone other than the person in the box is the one who opens it. As a further safeguard against spamming this can happen at most once every minute.

Incoming5643 · 2015-09-11T22:04:49Z

Alright well I implemented the old sprite anyways, but if you get something better drawn just post it here and I'll update it.

Also added the ! easter egg in this commit

ghost · 2015-09-12T02:16:01Z

@Incoming5643 https://www.dropbox.com/s/wjkvi28quub4kip/MGS.dmi?dl=0 Beep

Incoming5643 · 2015-09-12T03:30:55Z

Done.

Also fairly obvious to anyone who looks at the the code but no, as far as I can tell we can't use THE sound for the alert easter egg, I can't find anything on its licensing, which probably means it was in house.

ghost · 2015-09-12T03:32:07Z

Yay!

Iamgoofball · 2015-09-12T04:55:54Z

@Incoming5643 we can do a very close replica + idk i think parody act???

AKlimentyev · 2015-09-12T08:20:47Z

It should be partially invisible to sec officers at range

tigercat2000 · 2015-09-12T15:09:25Z

code/game/objects/structures/crates_lockers/closets.dm


 /obj/structure/closet/New()
 	..()
+	if(type == /obj/structure/closet && ticker && ticker.current_state == GAME_STATE_PREGAME && prob(20)) //only roundstart generic closets


Couldn't this be put under closet/initialize()?

Probably. I wasn't 100% sure if structures that were created during the initialization step would be properly initialized themselves, so I just stuck with New()

That seems to be a really shitty thing for anyone who maps. As you can no longer properly map a crate that will actually be a crate for sure.

Would be a lot better with some new item that has chance to be a crate or cardboard box, and then editing that to the map. Instead of forcing 20% of crates that are and ever will be to be a cardboarbox.

It's only generic closets, the grey ones with nothing on them that are found almost exclusively in maintenance. All crates are still crates, and all special lockers are still those lockers.

I can do that later and revert this bit, it's just nothing screams "This will conflict for the next six weeks" quite like a map change that touches a lot of tiles

Put this in initialise or remove it and PR it later.
Merge chances missed: 1.

callanrocks · 2015-09-13T07:33:33Z

They should make you unable to be tracked by the AI like agent cards yes/yes/yes?

ghost · 2015-09-13T15:22:27Z

@RemieRichards Merge pls

theOperand · 2015-09-13T15:30:24Z

code/game/objects/structures/crates_lockers/closets/cardboardbox.dm

+				egg_cooldown = 1
+				spawn(600)
+					egg_cooldown = 0
+	..()


tbh im fine with people sneaking around in cardboard boxes but this is an """easter egg""" that triggers literally any time a box with a mob in it is opened, which is pretty shitty and will get obnoxious really fast.

it's actually only once per minute.
but yeah this is obnoxious.

Perhaps it could be a subtype that does it?

It only happens when the person who opens the box ISN'T the person in the box. But yeah originally it was going to opperate on a low probability chance or only be able to activate once per box.

What would be more palatable to people?

if(prob(TCMB*0.5)) for maximum unreadability :^)

make it once every 5 minutes?

Come in from downwind, then pull up fast! Get ready to fast rope down to Shell One! Five minutes to ETA! Alpha, your top priority is to rescue and safeguard the President! Team Bravo, watch out for Stillman's back, and get those C4's disarmed!

Dorsisdwarf · 2015-09-17T12:24:32Z

code/game/objects/structures/crates_lockers/closets/cardboardbox.dm

+
+/obj/structure/closet/cardboard/relaymove(mob/user, direction)
+	if(opened || move_delay || user.stat || user.stunned || user.weakened || user.paralysis || !isturf(loc) || !has_gravity(loc)/*|| Kawanishi-Noseguchi || Kinunobebashi || Takiyama || Uguisunomori || Tsuzumigataki || Tada || Hirano || Ichinotorii || Uneno || Yamashita || Sasabe || Kofudai || Tokiwadai || Myokenguchi*/)
+		return


Incoming5643 · 2015-09-17T15:33:16Z

Blame me not being terribly familiar with how animations work. You don't want to know how long it took me just to see that little ! work right.

But yeah calling non existent parents probably isn't required 👶

Niknakflak · 2015-09-17T23:18:18Z

!

imtakingabreakdontatme · 2015-09-18T12:39:45Z

code/game/objects/structures/crates_lockers/closets/cardboardbox.dm

+				alerted << sound('sound/machines/chime.ogg') //HQ HQ!
+				egg_cooldown = 1
+				spawn(3000)
+					egg_cooldown = 0


Shouldn't all this egg cooldown be something along the lines of

if(egg_cooldown < world.time)

And then egg_cooldown = world.time + 3000

Instead of using spawn?

But then I'd have to code in midnight rollover protection

Is that spess y2k

basically yeah

tedward1337 · 2015-09-19T01:31:15Z

!

Incoming5643 · 2015-09-19T01:58:22Z

I've noticed a very confusing trend where the more lackadaisical and impulsive a pull request I make the more scrutiny it comes under. It's just a booooooooooox.

tedward1337 · 2015-09-21T03:47:37Z

More like
Tacti-COOL espionage action am I right guys??

Eddlicious · 2015-09-21T17:43:46Z

Could you fold these large cardboard boxes? Y'know, for... Tactical uses.

Razharas · 2015-09-23T00:11:30Z

Plz remove silly comments

Incoming5643 · 2015-09-23T03:35:48Z

You may pick one to be removed, but whichever you spare must remain enshrined.

PKPenguin321 · 2015-09-24T21:59:41Z

fuckin' finally

WJohn added the Feature Exposes new bugs in interesting ways label Sep 11, 2015

Incoming5643 changed the title ~~[Needs sprites] Adds large cardboard boxes~~ Adds large cardboard boxes Sep 11, 2015

You are above even The Box. I hereby award you the title of Big Box.

84eda74

tigercat2000 reviewed Sep 12, 2015
View reviewed changes

theOperand reviewed Sep 13, 2015
View reviewed changes

Dorsisdwarf added the Ready for Review/Merge label Sep 16, 2015

Dorsisdwarf reviewed Sep 17, 2015
View reviewed changes

Patches up some animation mechanics misconceptions

d2a1028

imtakingabreakdontatme reviewed Sep 18, 2015
View reviewed changes

Razharas merged commit d2a1028 into tgstation:master Sep 24, 2015

Adds large cardboard boxes #11706

Adds large cardboard boxes #11706

Conversation

Incoming5643 commented Sep 10, 2015

Incoming5643 commented Sep 10, 2015

Iamgoofball commented Sep 10, 2015

Nitrousoxide commented Sep 10, 2015

PKPenguin321 commented Sep 10, 2015

duncathan commented Sep 10, 2015

harmonyn commented Sep 11, 2015

Fox-McCloud commented Sep 11, 2015

Aloraydrel commented Sep 11, 2015

Kromgar commented Sep 11, 2015

ike709 commented Sep 11, 2015

ghost commented Sep 11, 2015

peoplearestrange commented Sep 11, 2015

Incoming5643 commented Sep 11, 2015

Fox-McCloud commented Sep 11, 2015

ghost commented Sep 11, 2015

Incoming5643 commented Sep 11, 2015

ghost commented Sep 12, 2015

Incoming5643 commented Sep 12, 2015

ghost commented Sep 12, 2015

Iamgoofball commented Sep 12, 2015

AKlimentyev commented Sep 12, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

callanrocks commented Sep 13, 2015

ghost commented Sep 13, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Incoming5643 commented Sep 17, 2015

Niknakflak commented Sep 17, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tedward1337 commented Sep 19, 2015

Incoming5643 commented Sep 19, 2015

tedward1337 commented Sep 21, 2015

Eddlicious commented Sep 21, 2015

Razharas commented Sep 23, 2015

Incoming5643 commented Sep 23, 2015

PKPenguin321 commented Sep 24, 2015