New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various mining additions, fixes, nerfs and buffs (ready for review/merge). #13102
Conversation
Not liking the reduced ore values, but liking everything else so 👍 |
They're not unilaterally reduced, and if science upgrades the ore machine mining will have more points than they can ever use anyway. |
i dont see why you lowered gold and silver |
I am not sure about the randomized yields, but I guess it is better than flat out nerfing them... |
Well yeah but in my experience even if I'm literally screaming at Science over the radio to upgrade it, it's only a 30/70 on if they actually do it. Also the upgraded resonator is way overpriced. 3 to 5 fields? Something that isn't even bought in the first place? Nobody will use it. Jaunter price increase is also too much considering miners are the only ones who can safely use it. If they give it to someone like a gang boss or someone without a hardsuit, there's basically a 50/50 on if they teleport to inside a window on the toxins test satelite, or a window in arrivals safely. That brute first aid kit tho 👍 👍 👍 👍 👍 Upgraded KA might be slightly overpriced but regular KA is already god-tier so it's probably fine. |
upped points slightly -- plasma now 12, gold/silver now 16. Also, I don't think people are taking upgraded machines into account -- have R&D upgrade the machine and you can buy literally anything you want for all time goddamnit I was hoping I wouldn't have to fuck with any maps fucking hell |
…o newmininggear Conflicts: _maps/map_files/DreamStation/dreamstation04.dmm
Yeah you really only buy diamond pickaxes for style points. By the time it's worth it to buy one you have more points than you ever need. |
Bring back the mining glasses that let you see ore. removing them was a bad idea. |
^ yeah that |
Yeah, do that or make advanced mining scanner standard issue. It's not fun having to rape page down to see ore. It would make mining not tedious as fuck |
Please make a more explicit changelog |
@@ -119,6 +119,10 @@ | |||
flag = "bomb" | |||
range = 3 | |||
|
|||
/obj/item/projectile/kinetic/upgraded | |||
damage = 12 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4000 points for an extra 8 damage?
lolno
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
like I said, any higher damage and it can two-hit people in space, which is OP. 12 ranged damage is still pretty damn good, better than a laser
also, this is just part of the upgrade, it also includes a higher range and better cooldown
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4000 mining points of material sent to centcomm could buy ten laser rifles for thi-
wait a minute, lasers are 20 damage. 12 is fire extinguisher tier.
Howabout instead of nerfing yields you remove the godawful "infinite stuff!" mining machine upgrade. We had systems in place that worked finr there is no need to scrap them over poorly balanced upgrades. |
yields have not been nerfed, they just have a bit of unpredictability and fun now please elaborate on "poorly balanced" |
Is it possible for there to be a dedicated 'Kill Monsters' Item for 'Miners'? I was thinking like some sort of collapsable Energy Bow. Would be nice to have one dedicated miner killing the monsters while the others mine. COOPERATION! |
That is why you have the KA. It is a miner's primary weapon, with the mining ability as a bonus. The miner should only use the KA to mine only if he does not have a superior tool. |
Requiring that science upgrade the ore machine for you to be able to afford anything good is silly |
they don't, though, even if science never touches the ore machine, after only ONE good run you have 5000+ points. with the new points, the only difference is you won't be able to buy out the whole machine in one sitting |
That's how it is now though BGO, with you reducing the plasma costs by over 1/3, and since it usually is a massive portion of how many ores miners bring in, this will likely bring the points you earn from 5000 down to around 3500 in a worst case scenario, not counting being lucky/unlucky with ore numbers. |
Plasma is valuable in terms of points for fluff reasons. NT wants you to be mining it. Otherwise this all looks good. |
Yea don't nerf plasma as much, it's supposed to be the shit you actually ship off for cargo and miners should be encouraged to mine it. I also think that this doesn't go far enough. Science has become the exclusive domain of "the department that gets literally all the cool shit". Scientist is by far the most popular job and the sheer amount of insane stuff they can get for themselves is completely out of proportion with the rest of the station, when a scientist wakes up at the start of every shift they ask themselves "Do I want to become to leader of a fearsome monster army who can stop time, duplicate myself, and generate almost infinite resources? or would I prefer to become a master of technology, stomping around in a nigh-invulnerable mech with some of the most powerful weapons available and with enough guns, advanced HUDs, implants, and tools to make even the greatest powergamer blush with envy? or would I just rather step into toxins and become a god of death?" Given the amount of game-breaking insane equipment that science can get with low effort and low risk, its a little silly how much we've focused on restricting what miners can get for a high effort and high risk job. Add a prototype jetpack with the capacity of regular jetpacks that can fit in the "extra" hardsuit slot (and work) and backpacks. Let them make a shield out of goliath plates that is significantly more robust than a riot shield. Let them acquire a material that removes their hardsuit slowdown (I mean xenobio already gets this). |
No need to be that complicated. Hardsuits already have support for inbuilt jetpacks, simply create a jetpack inside the suit using its "jetpack" var. Replace the buyable jetpack in the vendor with one that attaches to a hardsuit. EDIT: I just coded it, if you do it this way, you will need to remember to add the jetpack verbs. Inventory management is already annoying for a miner, I do not know how well they would manage having a shield added to that, as well. Even so, I have had miners ask for shields before. |
Yeah but they slow people down pretty severely and since the burn damage is full body, unless someone has tons of kelotane or burn patches in them they're gonna be hit by what is basically a lethal disabler. |
these are all cool ideas but out of the scope of this PR |
RAZHARAS NO RAZHARASING, I NEED TO RE-ADD A SPRITE LATER TODAY |
make ka upgrade 15. the moral of the story is don't fight a miner in space. |
The classic blunder. Fighting a miner in space or in melee. |
idk man do we really want to go down the route where miners can 2-hit people in space and get a 15-brute RANGED weapon I'm not 100% opposed to it (and I forgot to factor in the fact that in space you probably have armor to soak some of the damage) but it seems like the kind of thing that's a bit OP to get from, like, one mining trip. Seriously one mining trip gives you 4000+ points on its own, and if the machine is upgraded 3x that. |
Ehh, it's a little bit of a gray area but not something that should really be that big of a deal. If it becomes really really abused in the future we could always just nerf it down again, I suppose. Also on an unupgraded machine, that's one really long mining trip with an ore box. So spending the majority of your points on a really good thing should be okay since you might not have enough for even a jetpack on top of that. |
There's nothing wrong with a 5-tile range 15 brute weapon. Throwing a hatchet does that much, and is longer range too. The balancing point should be it's x4 damage in space, not it's base damage |
Oh man, in space it's literally a revolver damn. What's the in-atmos damage of the regular KA? |
40, it's 4x base |
MAJOR UPDATE GET COMMENTS IN NOW |
@@ -141,7 +151,11 @@ obj/item/projectile/kinetic/New() | |||
var/turf/simulated/mineral/M = target_turf | |||
M.gets_drilled(firer) | |||
new /obj/item/effect/kinetic_blast(target_turf) | |||
|
|||
if(src.splash >= 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You know, since you would never have a negative value for "splash", you could just use if(spash)
for the same result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops
hang on for a second why are we having INDIVIDUAL NEW TYPES OF KINETIC ACCELERATORS instead of restoring the upgrades system I had in place from before |
why not? we have individual new types of pickaxes and drills. |
How about a gibtonite transporter lift so you can load multiple pieces of it at once. |
This has my seal of approval |
too long didn't read |
Various mining additions, fixes, nerfs and buffs (ready for review/merge).
I definitely approve of the changes here, only thing I could hope for would be something new for basilisks. Right now, they're not worth taking the damage to get the diamonds they provide. Other than that, can't think of anything I would really change with this. |
NOTE: EVERY NUMBER IN THIS PR IS OPEN TO TWEAKING
** Brute first-aid kit has been added for 600 points.
** Jaunter is now 600 points, in line with starting mining gear.
** For 400 points, miners can purchase an item that stabilizes hivelord cores, keeping them from going inert. This is limited in theory by how many hivelords spawn and in practice by how often miners bother do this, so having unlimited full heals isn't something I'm too worried about. I guess people can buy a ton of lazaruses but that takes a lot of points and patience.
** Diamond pickaxe is now 2500 points.
** A silver pickaxe, which performs between diamond and normal, has been added at the normal 1200 cost. The moral of this story is that if you want better tools, you need to actually leave your autism fort and cooperate with science.
** For 2400 points, miners can purchase an upgraded resonator, which can have 5 fields active, rather than 3.
** For 3000 points, miners can buy an upgraded kinetic accelerator, which does 11 base damage (up from 10), has one greater range, and has a slightly better cooldown.
🆑 bgobandit
rscadd: Due to changes in Nanotrasen's mining supply chain, ore redemption machines now offer a variety of upgraded items! However, certain items are more expensive. Point values for minerals have been adjusted to reflect their scarcity.
rscadd: Nanotrasen R&D has discovered how to improve upon the resonator and kinetic accelerator.
rscadd: After a colossal tectonic event on Nanotrasen's asteroid, ores are distributed more randomly.
rscadd: Bluespace crystals have been discovered to be ore. They will now fit into satchels and ore boxes.
rscadd: Mech advanced mining scanners now include meson functionality.
/:cl: