Adds a Synth Species #13122

RemieRichards · 2015-11-19T22:09:25Z

Changes

Adds Synth Species
Adds a method for species to react to being force set by an admin.

Synth Species

Imitates a species - Say mods, Icons, Mutant parts, etc.
When health reached disguise_fail_health their synthflesh falls off partially, revealing their metal skeleton beneath
Synthflesh can only be repaired by drinking the reagent, Synthflesh. Drunk synthflesh heals Synths more than synthflesh normal heals for.
/synth/military subtype has in built armour (25) and increased punch damage (+10)

Damaged skin (Correctly handles species)

Base icon_state adapted from Bay's IPCs, synthflesh automatically created from existing icons via code.

Idea adapted from https://tgstation13.org/phpBB/viewtopic.php?f=9&t=5212&p=134868#p134868
I spoke with GUN_HOG about him using this species datum for the constructed synths in the thread.

This can be used to have people spawn as their characters, and then become some kind of Synth Antag so they're still their character, but technically a synth.

🆑
add: Adds a Synth Species
add: Species can now react to being force set by admins, used for Synth species
/:cl:

…y reach 50 HP their skin partially falls off. Adds a method for species to react to being force set by an admin.

ChangelingRain · 2015-11-19T22:12:46Z

code/modules/mob/living/carbon/human/species_types.dm

+	safe_co2_max = 0
+	SA_para_min = 0
+	SA_sleep_min = 0
+	dangerous_existence = 1


They're not actually dangerous to be?
They might be attacked or killed, but they're not actually dangerous like plasmamen or shadowpeople are.

I forget why I set this var, I did it like an hour ago.
I do assume people wont be so friendly towards a robot with flesh dangling off of it though.

Yeah this is for stuff that's deadly to be under normal circumstances rather than deadly to be because you're a scary antag.
If there's a code reason for it it's okay I guess though.

well dangerous_existence species are converted to humans when they get normal antag roles, so I'd like that here.

ExcessiveUseOfCobblestone · 2015-11-19T23:14:00Z

well dangerous_existence species are converted to humans when they get normal antag roles, so I'd like that here.

Wait so you can metagame someone by looking at their name?

IE if I'm plasmaman and I'm named Xenon 44, I get traitor tot and become human, people will know I'm a traitor tot because I'm a human with a Pbro's name?

daman997 · 2015-11-20T01:02:28Z

this looks cool 👍

Zilenan91 · 2015-11-20T02:21:32Z

I could see there being 1 or 2 of these at round start every round with the "Avoid detection" antag objectives. They allow antagonistic freedom as well as preventing mass murderbone.

Incoming5643 · 2015-11-20T04:24:37Z

Being an antag and having dangerous_existence does NOT turn you into a human. Currently dangerous_existence only makes sure that magic shit doesn't turn people into suitless plasmamen and the like.

RemieRichards · 2015-11-20T13:29:00Z

@Incoming5643 it does turn them Human, it's in @as334's PR. I had thought it already did this partially, but if you claim not, then suuuure.

@ExcessiveUseOfCobblestone it's not all antag roles, it's the weirder ones like Nuke Ops, who obviously can rename themselves anyway.

@Zilenan91 ya, Stealth would very VERY much be the focus of this as a side antag, but for now, admin species. Admins can probably trial how they think it should go too, like how shadowling was an event long before it was a gamemode.

…hem. Moves "Op" stuff to a /synth/military subspecies.

Supermichael777 · 2015-11-20T21:35:24Z

now all we need is the ability for the combat synths to hack cloning computer boards and HUD icons and we can have another shitty team conversion antag!

they should repair like augs Tbh. tox and oxy imunity too.

Aranclanos · 2015-11-22T22:33:12Z

code/modules/mob/living/carbon/human/species_types.dm

+
+
+/datum/species/synth/handle_chemicals(datum/reagent/chem, mob/living/carbon/human/H)
+	if(chem.id == "synthflesh")


aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa

it's how it's all done I'm afraid, check every other handle_chemicals, and everything else about the reagent system, it's all chem.id checks.

should be a blame goof tag

make this reagent do some dna affect() new proc or something

this is shit and there's gotta be a better way to redo this, i want to strangle whoever set this handle_chemicals() shit in species code up

@RemieRichards actually no, in SANE CHEMISTRY USES we have a has_reagent() proc or some shit, and quite frankly this should be handled on the reagent.

@Iamgoofball look at handle_chemicals for all species that have one, nerd.

Supermichael777 · 2015-11-24T20:20:48Z

but is it merge ready?

MMMiracles · 2015-12-04T01:30:39Z

dont let the terminator die

RemieRichards · 2015-12-04T14:57:23Z

It's been merge ready for days (it's just conflicting now) the thing Aran's on about is inconsistent to the current species+reagent code and I won't be doing it.

I'll fix conflicts soon.

…o Synths Conflicts: icons/mob/human.dmi

RemieRichards · 2015-12-05T01:11:51Z

@tgstation/commit-access cmon you guys

GunHog · 2015-12-05T01:17:05Z

Yes! For a Remie Richards feature to be done in less than a month is amazing! MERGE!

Iamgoofball · 2015-12-05T01:44:05Z

code/modules/mob/living/carbon/human/species_types.dm

+	if(chem.id == "synthflesh")
+		chem.reaction_mob(H, TOUCH, 2 ,0) //heal a little
+		handle_disguise(H) //and update flesh disguise
+		H.reagents.remove_reagent(chem.id, REAGENTS_METABOLISM)


aaaAAAAAAAAAAAAAAAAAAAAAAA
AAAAAAAAAAAAAAAAAAAAAAAAAA

standardize this with the proper chemistry procs

this IS proper chemistry procs!

can't you just add a species check to synthflesh to heal the disguise

Handling a species thing anywhere but species

Cmon goof.

using direct chem.id string checks with ==

using checks THE REST OF THIS INSTANCES OF THIS PROC DO

cmon now goof, we both know the entire SYSTEM is a sack of garbage, and fixing this one instance changes -nothing-

Little things add up

Dorsisdwarf · 2015-12-09T14:26:48Z

rrrrrrrrrrrrrrrrrrr

optimumtact · 2015-12-09T20:57:54Z

eeeeeeeeeeeeeeeee

GunHog · 2015-12-09T21:07:19Z

This is a RemieRichards feature. A minimum of 30 days must pass before she can complete it. You are 10 too early!

(I am joking RR plz no hurt me)

RemieRichards · 2015-12-09T21:07:55Z

@GunHog Before I can complete it? IT'S BEEN COMPLETE FOR DAYS.

Jazaen · 2015-12-09T21:22:53Z

Where is Raz when you need him?

Cheridan · 2015-12-10T02:10:54Z

7.6/10 its ok

Adds a Synth Species

PKPenguin321 · 2015-12-10T02:20:24Z

happening

Dorsisdwarf · 2015-12-11T08:06:47Z

DUDUDUDUDUH

Jazaen · 2015-12-11T22:55:35Z

Now, we just need someone to add a procedure of gluying all borg pieces onto a special frame and adding brain/posibrain with some blood for identity, and voila, you can hide on derelict in a base with one way teleporter, abducting crew and replacing them for fun and profit.

Adds a Synth Species, Admin only atm, Imitates a species and when the…

2c46767

…y reach 50 HP their skin partially falls off. Adds a method for species to react to being force set by an admin.

RemieRichards added the Feature Exposes new bugs in interesting ways label Nov 19, 2015

ChangelingRain reviewed Nov 19, 2015
View reviewed changes

Synths can now ingest Synthflesh to rebuild their disguise AND heal t…

be67425

…hem. Moves "Op" stuff to a /synth/military subspecies.

Aranclanos reviewed Nov 22, 2015
View reviewed changes

Jordie0608 added the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Nov 29, 2015

Merge branch 'master' of https://github.com/tgstation/-tg-station int…

00bfe18

…o Synths Conflicts: icons/mob/human.dmi

RemieRichards removed the Merge Conflict Adding upstream files to your repo via drag and drop won't resolve conflicts label Dec 4, 2015

Iamgoofball reviewed Dec 5, 2015
View reviewed changes

Dorsisdwarf added the Ready for Review/Merge label Dec 9, 2015

Cheridan added a commit that referenced this pull request Dec 10, 2015

Merge pull request #13122 from RemieRichards/Synths

5004bcd

Adds a Synth Species

Cheridan merged commit 5004bcd into tgstation:master Dec 10, 2015

tgstation-server added a commit that referenced this pull request Dec 10, 2015

Automatic changelog generation for PR #13122

fae72d6



		/datum/species/synth/handle_chemicals(datum/reagent/chem, mob/living/carbon/human/H)
		if(chem.id == "synthflesh")

Adds a Synth Species #13122

Adds a Synth Species #13122

Conversation

RemieRichards commented Nov 19, 2015

Changes

Synth Species

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ExcessiveUseOfCobblestone commented Nov 19, 2015

daman997 commented Nov 20, 2015

Zilenan91 commented Nov 20, 2015

Incoming5643 commented Nov 20, 2015

RemieRichards commented Nov 20, 2015

Supermichael777 commented Nov 20, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Supermichael777 commented Nov 24, 2015

MMMiracles commented Dec 4, 2015

RemieRichards commented Dec 4, 2015

RemieRichards commented Dec 5, 2015

GunHog commented Dec 5, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Dorsisdwarf commented Dec 9, 2015

optimumtact commented Dec 9, 2015

GunHog commented Dec 9, 2015

RemieRichards commented Dec 9, 2015

Jazaen commented Dec 9, 2015

Cheridan commented Dec 10, 2015

PKPenguin321 commented Dec 10, 2015

Dorsisdwarf commented Dec 11, 2015

Jazaen commented Dec 11, 2015