Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DiscStation Cargo Update + stuff #13133

Merged
merged 5 commits into from Nov 26, 2015

Conversation

Strathcona
Copy link
Contributor

Fixes #13072

Revamps and widens DiscStation cargo and manages to fix all the issues with the sorting room, airless shuttle and more.

  • Added a few more cosmetic items to the halls like mini gardens and a snack bar
  • Readded disposals to medbay
  • Fixed a few lighting issues
  • Redid the rather bland and boring Cafeteria as an upscale coffee bar, Spacebucks (taking suggestions on the name)
  • Fixed a few minor area issues with nearspace
  • Added a space disposals to xeno

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @none to be a potential reviewer.

@Strathcona
Copy link
Contributor Author

Oh, I guess this is a mapping PR so why not try @WJohn as a reviewer mention-bot?

@GunHog
Copy link
Contributor

GunHog commented Nov 20, 2015

Redid the rather bland and boring Cafeteria as an upscale coffee bar, Spacebucks (taking suggestions on the name)

Just name the area "bar". Use a barsign to allow the players to customize their establishment themselves.

@Strathcona
Copy link
Contributor Author

There's already a bar on discstation with the diner aesthetic and it's got the sign and everything. Here's a side by side of the new cafe

image

@Dorsisdwarf
Copy link
Contributor

Wood airlocks detected abort abort

@Strathcona
Copy link
Contributor Author

What's wrong with wood airlocks?

@Supermichael777
Copy link
Contributor

nominally they cannot be fixed if broken

@ChangelingRain
Copy link
Contributor

Also they look like shit, oh god.

@Strathcona
Copy link
Contributor Author

Wait, you can't make wooden airlocks from wood? If so I'll just make them glass. They look slightly better in game because the overlay fills up the holes so they're solid.

@WJohn WJohn added Map Edit Fix Rewrites a bug so it appears in different circumstances labels Nov 20, 2015
added a bunch more fire extinguishers
@Hatfish
Copy link
Contributor

Hatfish commented Nov 21, 2015

Have you fixed that one issue with the shuttle missing a wall yet?

@Strathcona
Copy link
Contributor Author

The cargo shuttle was missing windows on the engines if that's what you mean.

@Hatfish
Copy link
Contributor

Hatfish commented Nov 22, 2015

No, there's a gaping hole into space on the left side of the shuttle, near the purple flooring. At least, it was like that the last two times I saw it.

@Strathcona
Copy link
Contributor Author

@Hatfish Looks like that was fixed. This is merge ready by the way.

@Strathcona
Copy link
Contributor Author

Added the new pods into this as well. Merge please.

@Strathcona
Copy link
Contributor Author

Can we some Razharasing in here @Razharas?

duncathan added a commit that referenced this pull request Nov 26, 2015
@duncathan duncathan merged commit e596033 into tgstation:master Nov 26, 2015
@Strathcona
Copy link
Contributor Author

Thanks Duncathan.

@Strathcona Strathcona deleted the DiscStationRefresh branch November 26, 2015 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disc Station Cargo is awful
9 participants