Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eshields have 100% block vs energy ,but 0 vs everything else #13785

Merged
merged 1 commit into from Dec 21, 2015

Conversation

imtakingabreakdontatme
Copy link
Contributor

No description provided.

@@ -54,8 +54,6 @@
var/active = 0

/obj/item/weapon/shield/energy/hit_reaction(mob/living/carbon/human/owner, attack_text, final_block_chance)
if(active)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm this a mistake or ya removing it from working?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't work at blocking things.

But it works at reflecting things.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep just read rest of code and worked it out

@ghost
Copy link

ghost commented Dec 18, 2015

This is dumb. Energy shields are already too expensive to be viable, there isn't a reason to further piledrive them into the ground. 👎

@imtakingabreakdontatme
Copy link
Contributor Author

This is important because of another change I am making please hold

@ghost
Copy link

ghost commented Dec 18, 2015

Then it might be a good idea to put that in the OP instead of having no description whatsoever.

@Zilenan91
Copy link

Yeah currently this is just a nerf for no reason on an item that can already be shat on by hard counters.

@imtakingabreakdontatme
Copy link
Contributor Author

50% blockrate against bullets and 50% damage reduction from bullets on the nuke op armour
hard counters

Uh huh

@Zilenan91
Copy link

stunbaton/prod

@duncathan
Copy link
Contributor

@Zilenan91 he has another PR open that lets shields block stun batons

@Zilenan91
Copy link

I saw it

@WJohn WJohn added the Balance Changes to functionality that modifies how effective certain methods are at powergaming label Dec 18, 2015
@WJohn
Copy link
Contributor

WJohn commented Dec 18, 2015

I'm okay with this.

@Niknakflak
Copy link
Contributor

I always saw them as like the halo shields the jackels had which did in fact block bullets. I'd rather just keep them the way they were.

@apuh3
Copy link
Contributor

apuh3 commented Dec 19, 2015

I'm okay with this as long as the eshield gets 20 throwforce while active

@Cheridan
Copy link
Contributor

wouldn't this make just riot shields better than energy shields

@imtakingabreakdontatme
Copy link
Contributor Author

wouldn't this make actual riot shields better than energy shields

Depends on what weapons the enemy is using.

It's still a 100% chance to reflect lasers/tasers back at the enemy, which is significantly stronger than the riot shield.

@tkdrg
Copy link
Contributor

tkdrg commented Dec 21, 2015

Sure, we can try this out, with the baton thing. I think it's for the best.

tkdrg added a commit that referenced this pull request Dec 21, 2015
Eshields have 100% block vs energy ,but 0 vs everything else
@tkdrg tkdrg merged commit bbe96ca into tgstation:master Dec 21, 2015
@Lumipharon
Copy link
Contributor

This is important because of another change I am making please hold
merges it anyway

k.

@tkdrg
Copy link
Contributor

tkdrg commented Dec 21, 2015

@Lumipharon the other change was the stun baton change that kor closed in favor of xxalpha's and that I merged at the same time.

@Lumipharon
Copy link
Contributor

What, but that literally has nothing to do with this change, considering this pr makes e-shield have 0 chance to block batons at all?

Kor, pls

@tkdrg
Copy link
Contributor

tkdrg commented Dec 22, 2015

This PR has nothing to do with batons, Lumi. The end result of both PRs is that eshields have 100% vs energy, 100% vs batons, and 0% vs bullets.

@Lumipharon
Copy link
Contributor

Ok well that's just very confusing wording then, since this pr implies that only energy weapons (batons having never been included with them) are blocked by eshields, and nothing else.

@tkdrg
Copy link
Contributor

tkdrg commented Dec 22, 2015

That's what this PR does, true. The baton thing is another PR entirely that I merged at the same time like Kor requested, and I linked above (#13823).

@Jordie0608
Copy link
Member

no changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Changes to functionality that modifies how effective certain methods are at powergaming
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet