New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eshields have 100% block vs energy ,but 0 vs everything else #13785
Conversation
@@ -54,8 +54,6 @@ | |||
var/active = 0 | |||
|
|||
/obj/item/weapon/shield/energy/hit_reaction(mob/living/carbon/human/owner, attack_text, final_block_chance) | |||
if(active) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Umm this a mistake or ya removing it from working?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't work at blocking things.
But it works at reflecting things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep just read rest of code and worked it out
This is dumb. Energy shields are already too expensive to be viable, there isn't a reason to further piledrive them into the ground. 👎 |
This is important because of another change I am making please hold |
Then it might be a good idea to put that in the OP instead of having no description whatsoever. |
Yeah currently this is just a nerf for no reason on an item that can already be shat on by hard counters. |
Uh huh |
stunbaton/prod |
@Zilenan91 he has another PR open that lets shields block stun batons |
I saw it |
I'm okay with this. |
I always saw them as like the halo shields the jackels had which did in fact block bullets. I'd rather just keep them the way they were. |
I'm okay with this as long as the eshield gets 20 throwforce while active |
wouldn't this make just riot shields better than energy shields |
Depends on what weapons the enemy is using. It's still a 100% chance to reflect lasers/tasers back at the enemy, which is significantly stronger than the riot shield. |
Sure, we can try this out, with the baton thing. I think it's for the best. |
Eshields have 100% block vs energy ,but 0 vs everything else
k. |
@Lumipharon the other change was the stun baton change that kor closed in favor of xxalpha's and that I merged at the same time. |
What, but that literally has nothing to do with this change, considering this pr makes e-shield have 0 chance to block batons at all? Kor, pls |
This PR has nothing to do with batons, Lumi. The end result of both PRs is that eshields have 100% vs energy, 100% vs batons, and 0% vs bullets. |
Ok well that's just very confusing wording then, since this pr implies that only energy weapons (batons having never been included with them) are blocked by eshields, and nothing else. |
That's what this PR does, true. The baton thing is another PR entirely that I merged at the same time like Kor requested, and I linked above (#13823). |
|
No description provided.