New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map Template Load Verb + Maploader Improvements #13852
Conversation
…r where they (or their ghost) is standing.
What with lava ruins and such i think all these should get unified datums that preload their properties. But i guess that can wait. |
What would you want datumized? The main drawback I see is that your areas will be the same in each 'paste' of the map. |
@octareenroon91 with a datum for each "paste" you could "un-load" them, but I dont think that's that useful right now. |
Ah, very true. |
…assumptions that the coordinates exist (NO MORE RUNTIMES AT MAP EDGES WOOO!)
oooohhhhh shiny |
Is there any limitation reasoning why a system similar to midi uploading be used to upload your own custom .dmm past invalid paths? Most station maps average around 1.5MB, with meta being the biggest at around 2MB so I'd assume uploading little segments like this wouldn't be that intensive. |
literally just because I don't know the exact procs for sending something to the server (things like VVing icon just use "as icon" which apparently defaults to the user's PC, which I guess automatically does the transfer, I THINK there's an "as file" in which case I'd just ban non .dmm files and that'd be that) tl;dr I'll do it if I can figure it out. |
@RemieRichards |
@Jordie0608 ah excellent! the 1MB limit should be fine too, as previously mentioned, the "small shuttle" here is only 1.9 kilobytes. |
mso files uploaded to the server go to byond\cache folder yes? |
@Jordie0608 I'm going to assume that's an IRC log dump, and not you going insane :P |
Apparently < and > are markdown tags |
hell yes. |
…her admins, does NOT persist between rounds.
var/map = input(usr, "Choose a Map Template to upload to template storage","Upload Map Template") as null|file | ||
if(!map) | ||
return | ||
if(!findtext("[map]",".dmm")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't you use copytext
to make sure it isn't something like innocent_map.dmm.mp4.swf.exe
EDIT: not that extension matters anyway, and we're supposed to trust admins but eh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose so.
Map Template Load Verb + Maploader Improvements
also I just thought, could this work for holodeck/thunderdome templates? |
It would make the holodeck system easier to maintain since you don't have to map onto z2.dmm . |
Map Templates:
Includes two examples:
Example naming scheme: "size_quick-description-or-title_instance-number"
I'd like this naming scheme to be followed, but it's not necessary
(I might swap size and title around, so "asteroid_small" appears at the top)
Maploader Improvements:
for(X = 1, X<=some_max, X++)
loops replaced with the much fasterfor(X in 1 to some_max)
format, removes the 1-2ms delay after loading a maptemplate, woo!