Adds sharpening blocks #15519

PKPenguin321 · 2016-02-14T06:19:45Z

Two can be found in the kitchen vendor.

They are single-use. When a weapon is used on them, it gains the prefix "sharpened," gets the SHARP flag (allowing it to butcher things), and has it's force/throwforce increase by 5 4 up to a maximum of 15 12 30. If an item already has 15 12 30 or higher force (or throwforce (really only energy swords will have this)), they cannot be sharpened.

This also adds an admin variant, the super sharpening block, that makes an item do 200 damage on hit/throw and gain the prefix "super-sharpened."

~~Items with block chance cannot be sharpened. Blame zilenan~~ Only items that are already sharp can be sharpened.

Yes, you can have "the sharpened sharpened rolling pin." Double prefixes can happen, but you'll only rarely see a prefix repeated once, and you should never see a prefix repeated more than twice (as by the time a third block is used, you'll have hit the force damage cap). This is intentional. By maintainer request, prefixes now go sharpened -> twice-sharpened -> thrice-sharpened You can no longer sharpen the same item more than once.

Two handed items get their wielded force increased rather than standard force.

Sprite by newfren.

🆑 PKPenguin321
rscadd: The kitchen vendor now contains two sharpening blocks.
rscadd: Only items that are already sharp (such as fire axes, knives, etc) can be sharpened. Items used on sharpening blocks become sharper and deadlier. The sharpening blocks themselves can only be used once, and you can only sharpen items once.
/:cl:

two can be found in the kitchen vendor

GunHog · 2016-02-14T06:20:17Z

code/game/objects/items/weapons/sharpener.dm

@@ -0,0 +1,38 @@
+/obj/item/weapon/sharpener
+	name = "sharpening block"


I think you are looking for "whetstone".

implying anybody knows what that is
implying people don't know what a sharpening block is

"sharpening block" is easier to recognize at a glance. *shrug

KazeEspada · 2016-02-14T06:21:23Z

Can't sharpen a fire axe or a cleaver.

GunHog · 2016-02-14T06:23:09Z

I expect this to have a similar effect to Goofball's deep fryer, in terms of me sharpening the silliest of things.

PKPenguin321 · 2016-02-14T06:23:33Z

I expect this to have a similar effect to Goofball's deep fryer, in terms of me sharpening the silliest of things.

Good, players should have fun with this. It's a pretty funny feature.

imtakingabreakdontatme · 2016-02-14T06:24:08Z

code/game/objects/items/weapons/sharpener.dm

+		src.desc = "[src.desc] At least, it used to."
+		used = 1
+		if(I.force > max)//if the item's force exceeds 15 after 5 force is added,
+			I.force = max//set it back to 15


No no no, you do

I.force = Clamp(I.force + 5, 0, max)

just replace these two lines with that one line?

Well no replace the whole I.force = I.force+ increment with Clamp, and then just remove the

If(I.force) stuff

Yeah replace everything here with clamp please

PKPenguin321 · 2016-02-14T06:24:19Z

Can't sharpen a fire axe or a cleaver.

tfw nerds would cut your head off while chanting "OVERPOWERED, OVERPOWERED, OVERPOWERED"

imtakingabreakdontatme · 2016-02-14T06:24:44Z

code/game/objects/items/weapons/sharpener.dm

+		if(I.force > max)//if the item's force exceeds 15 after 5 force is added,
+			I.force = max//set it back to 15
+		if(I.throwforce > max)//do this again for throwforce
+			I.throwforce = max


Same as above

I.throwforce = Clamp(I.throwforce + 5, 0, max)

imtakingabreakdontatme · 2016-02-14T06:34:47Z

and you should never see a prefix repeated more than twice (as by the time a third block is used, you'll have hit the 15 force damage cap).

Until I use it 3 times on my medkit or something

imtakingabreakdontatme · 2016-02-14T06:50:50Z

code/game/objects/items/weapons/sharpener.dm

+		I.sharpness = IS_SHARP
+		I.force = (I.force + increment)
+		I.throwforce = (I.throwforce + increment)
+		I.name = "[prefix] [I.name]"


I.name = "[prefix] [initial(I.name)]"

If you want to avoid multiple prefixes

idk man multiple prefixes is kinda silly (the fun kind of silly) and helps to show exactly HOW sharp whatever you're getting attacked by is, i think i want to keep it. if you as a maintainer do not like it i will remove it however.

I have added far sillier things than double sharpened objects so I will leave that up to other people

drynwyn · 2016-02-14T07:32:55Z

You should make em' orderable at cargo or put them in the autolathe or maybe make them spawn in maint, just so that if you want to get a whole bunch and sharpen everything for DANGERSTATION, you can.

PKPenguin321 · 2016-02-14T07:38:30Z

Until I use it 3 times on my medkit or something

the thing is, 3 prefixes is the max. 5x3 = 15, and at that point you're not able to get another prefix. not to mention you should only be getting 2 sharpening blocks in a round (not counting away missions/janky maps that might have more than 1 kitchen for whatever reason)

Fox-McCloud · 2016-02-14T09:02:46Z

code/game/objects/items/weapons/sharpener.dm

+		I.throwforce = (I.throwforce + increment)
+		I.name = "[prefix] [I.name]"
+		src.name = "dull [src.name]"
+		src.desc = "[src.desc] At least, it used to."


src is implied.

Also, sharpening blocks don't go dull....

I knew it, I just wasn't sure.

These sharpening blocks dull. They're made in space-china.

Fox-McCloud · 2016-02-14T09:03:12Z

Sharpening of species' claws when? =p

neersighted · 2016-02-14T15:38:58Z

code/game/objects/items/weapons/sharpener.dm

+
+/obj/item/weapon/sharpener/attackby(obj/item/I, mob/user, params)
+	if(used)
+		user << "<span class='notice'>The sharpening block is too dull to use again.</span>"


whetstone's don't go dull... how about 'too worn'?

KazeEspada · 2016-02-14T15:41:01Z

👎 makes every weapon a cleaver without nerfing them somewhere else and doesnt give a cleaver or fireaxe anything in return. COMPLETELY UTTERLY DEDTROYS WEAPON BALANCE.

drynwyn · 2016-02-14T16:40:07Z

You can get more then 2 by using vending machine restock modules

Razoozle · 2016-02-14T17:43:36Z

I'm gonna lean for a 👎 on this.

Incoming5643 · 2016-02-14T18:33:40Z

Sharpened Sharpened Sharpened Major space carp plushie of the world +15

PKPenguin321 · 2016-02-14T18:37:32Z

balance police have arrived 🚨 🚓 👮 🚔 🚨

COMPLETELY UTTERLY DEDTROYS WEAPON BALANCE.

oh no, another 15 brute weapon. the game is broken my friends

Zilenan91 · 2016-02-14T19:03:15Z

Additionally, you can also sharpen those chaplain staves twice to get a 15 brute, 50% block for everything murder machine.

sharpening now gives a message to bystanders telling what you sharpened items with any block chance of any kind cannot be sharpened. separation between shields and weapons is absolute. dull sharpening block -> worn out sharpening block increments in force/throwforce now use Clamp() adderol -> adderall might be some other changes that i forgot but this is really the important stuff

PKPenguin321 · 2016-02-14T19:41:50Z

you can no longer sharpen items with block chance

You can get more then 2 by using vending machine restock modules

kitchen vendor has no restock modules

Lumipharon · 2016-02-14T20:16:59Z

Sharpened sharpened bike horn.

Honk.

Zilenan91 · 2016-02-14T21:30:27Z

@PKPenguin321 Vend both sharpening blocks and nothing else then deconstruct the machine. It should drop all of the components needed to remake it, and once created, be left with 1 sharpening block and 1 less of something else.

Lumipharon · 2016-02-14T22:35:34Z

@Zilenan91 I can't say for kitchen vendors, but many vendors (such as engie vendors) canot be deconstructed, and so cannot be abused in this way.

Cheridan · 2016-02-22T05:22:12Z

@PKPenguin321 If you add a check for sharp objects then I'll merge this.

PKPenguin321 · 2016-02-22T06:23:37Z

sigh
fine, i'll do it tomorrow

Zilenan91 · 2016-02-22T06:24:25Z

If you want to restrict it to sharp items can you make the blocks do +5 brute each time too?

PKPenguin321 · 2016-02-22T06:24:54Z

that's what i'm thinking
but at the same time, muh balance
ill ask in coderbus

sharpening blocks can now only sharpen items that are already sharp, like knives, axes, etc. (super sharpening blocks don't care though) max damage from sharpening is now 30 (no esword/ninja sword sharpening), increment is still 4 though !!items can only be sharpened once!! twohanded items (fire axes, spears) have their force when wielded increased rather than normal force increasing

PKPenguin321 · 2016-02-23T01:04:07Z

big update, check the latest commit/the original post

Zilenan91 · 2016-02-23T01:09:57Z

What practical use is there in setting the max sharpness to 30? I can't think of a single weapon that can get there with a single sharpen.

PKPenguin321 · 2016-02-23T01:10:49Z

mainly just so you can't sharpen eswords tbh

Zilenan91 · 2016-02-23T01:13:29Z

Don't eswords do 30 brute rather than 31? I guess it would still mean that you can't sharpen it? And if you did it would just waste it right.

PKPenguin321 · 2016-02-23T01:14:23Z

you can't sharpen things that are 30 or higher, you can't sharpen an esword at all
unless for whatever reason it keeps sharpness when it's just a handle (which would be a bug on it's own), but the then sharpen would be wasted because when you turned it on it would set it back to 30

Fox-McCloud · 2016-02-23T03:27:42Z

This means that chef effectively has a 19 force weapon, every single shift.

The Axe now has an effective force of 28, and the spear has a force of 22.

The big winner in all of this, though, will be the chaplain--who will be able to attain a whopping 22 force weapon if he can get his hands on a block.

Zilenan91 · 2016-02-23T03:29:26Z

You can only sharpen things once

Fox-McCloud · 2016-02-23T03:34:38Z

You can only sharpen things once

Yeah, updated the math on it.

Zilenan91 · 2016-02-23T03:41:25Z

All of this is totally fine.

PKPenguin321 · 2016-02-23T04:46:35Z

yeah and in reality the blocks will most likely be long used up before a fireaxe/chaplain weapon can get to it (unless the chef is a sneaky antag, in which case i have no problem with this, because he's an antag let him do what he wants)

Fox-McCloud · 2016-02-23T05:10:09Z

Hmm...thoughts on making it a contraband item?

Zilenan91 · 2016-02-23T05:12:54Z

It's fine

Lumipharon · 2016-02-23T08:17:51Z

Holy fuck the discussion in this pr is still going.

imtakingabreakdontatme · 2016-02-23T20:30:54Z

Holy fuck the discussion in this pr is still going.

Adds sharpening blocks

PKPenguin321 · 2016-02-25T01:54:13Z

KazeEspada You cant even sharpen knives
KazeEspada because knives are IS_SHARP_ACCURATE
KazeEspada not IS_SHARP

thanks for pointing that out in this PR before it got merged instead of in IRC after it got merged 😭

GunHog · 2016-02-25T02:25:39Z

TESTING

PKPenguin321 · 2016-02-25T02:33:27Z

when you tested every part of your PR on every commit but the last one
when you test the last one but quiiiite thoroughly enough

i tested it with a spawned in fireaxe and a spawned in block because i had just implemented two handed shit (which worked) then tested it with a glass shard from a window i broke with the axe

both of these objects have IS_SHARP and it never occured to me to try something with IS_SHARP_ACCURATE

i'm a failure 😭

adds sharpeners

8bb9680

two can be found in the kitchen vendor

GunHog reviewed Feb 14, 2016
View reviewed changes

imtakingabreakdontatme reviewed Feb 14, 2016
View reviewed changes

Fox-McCloud reviewed Feb 14, 2016
View reviewed changes

AnturK added the Feature Exposes new bugs in interesting ways label Feb 14, 2016

neersighted reviewed Feb 14, 2016
View reviewed changes

tkdrg added the Controversial label Feb 20, 2016

Dorsisdwarf added the Balance Changes to functionality that modifies how effective certain methods are at powergaming label Feb 23, 2016

Cheridan added a commit that referenced this pull request Feb 25, 2016

Merge pull request #15519 from PKPenguin321/sharpened-bikehorn

26731ee

Adds sharpening blocks

Cheridan merged commit 26731ee into tgstation:master Feb 25, 2016

tgstation-server added a commit that referenced this pull request Feb 25, 2016

Automatic changelog generation for PR #15519

649eb49

PKPenguin321 deleted the sharpened-bikehorn branch February 25, 2016 02:13

Fox-McCloud mentioned this pull request Feb 25, 2016

Ports Whetstones ParadiseSS13/Paradise#3696

Merged

AKlimentyev pushed a commit to Shadowlightbackup/-tg-station that referenced this pull request Feb 27, 2016

Automatic changelog generation for PR tgstation#15519

f99ca46

		@@ -0,0 +1,38 @@
		/obj/item/weapon/sharpener
		name = "sharpening block"

Adds sharpening blocks #15519

Adds sharpening blocks #15519

Conversation

PKPenguin321 commented Feb 14, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KazeEspada commented Feb 14, 2016

GunHog commented Feb 14, 2016

PKPenguin321 commented Feb 14, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PKPenguin321 commented Feb 14, 2016

Choose a reason for hiding this comment

imtakingabreakdontatme commented Feb 14, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

drynwyn commented Feb 14, 2016

PKPenguin321 commented Feb 14, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Fox-McCloud commented Feb 14, 2016

Choose a reason for hiding this comment

KazeEspada commented Feb 14, 2016

drynwyn commented Feb 14, 2016

Razoozle commented Feb 14, 2016

Incoming5643 commented Feb 14, 2016

PKPenguin321 commented Feb 14, 2016

Zilenan91 commented Feb 14, 2016

PKPenguin321 commented Feb 14, 2016

Lumipharon commented Feb 14, 2016

Zilenan91 commented Feb 14, 2016

Lumipharon commented Feb 14, 2016

Cheridan commented Feb 22, 2016

PKPenguin321 commented Feb 22, 2016

Zilenan91 commented Feb 22, 2016

PKPenguin321 commented Feb 22, 2016

PKPenguin321 commented Feb 23, 2016

Zilenan91 commented Feb 23, 2016

PKPenguin321 commented Feb 23, 2016

Zilenan91 commented Feb 23, 2016

PKPenguin321 commented Feb 23, 2016

Fox-McCloud commented Feb 23, 2016

Zilenan91 commented Feb 23, 2016

Fox-McCloud commented Feb 23, 2016

Zilenan91 commented Feb 23, 2016

PKPenguin321 commented Feb 23, 2016

Fox-McCloud commented Feb 23, 2016

Zilenan91 commented Feb 23, 2016

Lumipharon commented Feb 23, 2016

imtakingabreakdontatme commented Feb 23, 2016

PKPenguin321 commented Feb 25, 2016

GunHog commented Feb 25, 2016

TESTING

PKPenguin321 commented Feb 25, 2016