Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chameleon Kit #15661

Merged
merged 12 commits into from Feb 25, 2016
Merged

Chameleon Kit #15661

merged 12 commits into from Feb 25, 2016

Conversation

Iamgoofball
Copy link
Contributor

dreamseeker_2016-02-21_01-05-33
dreamseeker_2016-02-21_01-05-24
🆑 Iamgoofball
rscadd: Adds the Chameleon Kit to the uplink for 4 telecrystals.
rscadd: It contains a Chameleon Jumpsuit/Exosuit/Gloves/Shoes/Glasses/Hat/Mask/Backpack/Radio/Stamp/Gun/PDA.
rscadd: The chameleon gun fires no-damage lasers regardless of what it looks like.
rscdel: The Voice Changer has been removed.
rscadd: The Voice Changer has been merged into the Chameleon Mask to encourage disguising, and help with attempted infiltration.
rscdel: The Chameleon Jumpsuit has been replaced by the Chameleon Kit in the uplink for the same price.
experimental: The Chameleon Shoes have noslip functionality so you can disguise with them.
experimental: The noslip shoes are still available for purchase for now, but they got free chameleon functionality. Death to the brown shoes meta.
tweak: All chameleon clothing items have lost the EMP vulnerability. This should be a much needed buff.
tweak: Keep in mind, just because it looks like armor, doesn't mean it is. They have very very minor defensive stats but in an actual fight you're still going to take a lot of damage from projectiles and the greyshirt with a toolbox.
experimental: Agent ID Cards can now use chameleon technology to look like any other ID card.
rscdel: Due to budget cuts, the Space Ninjas approaching the station will no longer have voice changing capabilities.
/:cl:

@ClumsyAlcoholic
Copy link

Increase price to 4TC and it's good

@Iamgoofball
Copy link
Contributor Author

No. Provide a reason.

A = input("Select [chameleon_name] to change it to", "Chameleon [chameleon_name]", A) in chameleon_list
if(!A)
return
if(istype(user, /mob/living/carbon))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iscarbon()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ale mao

@Firecage
Copy link
Contributor

2 TC is honestly....way to cheap. In my personnel opinion it should atleast be 8 TC.

@Iamgoofball
Copy link
Contributor Author

No. Provide a reason.

@Niknakflak
Copy link
Contributor

Provide a reason for keeping it cheap as fuck

strip_delay = 120

/obj/item/clothing/mask/gas/voice/space_ninja/speechModification(message)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where did these procs go?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah I should probably put that in the changelog

space ninja snowflake was too retarded for me to bother keeping and the person who redid it said they didn't care anymore/didn't give a response when I asked if they cared at all, so I axed it. No reason to keep it in since literally no one uses it and admins haven't spawned a ninja in literally fucking ages.

Then again, saying this is gonna make an admin go spawn a ninja and then pop out of the woodwork saying they make ninjas "all the time", so ¯_(ツ)_/¯

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing ninja anime voice

Nooo. Make it a dna mutation at least.
Ninjas are currently broken, which is why admins don't spawn them. @neersighted says he's gonna do a nanoui for spiderOS, so I'm waiting on that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ninjas are currently broken

Yeah no not reverting this.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use broken as a generalized term for the issues they have. Mainly broken as in balance wise in terms of invisibility.
The mask itself works fine. Leave it be.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DNA mutation is a perfect way to keep this. Do so @Iamgoofball

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do that in another PR, adding more mutations changes genetics up in regards to getting things.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mask itself works fine. Leave it be.

it isn't compatible with the changes and I can't be assed to snowflake out the chameleon functionality for an already snowflakey voice changer special snowflake subtype for NINJA.

@KazeEspada
Copy link
Contributor

Because its a disguise kit. Its defensive. The price should be cheap.

@Niknakflak
Copy link
Contributor

Half the shit he changed was more expensive that 2 TCs and now it's all bundled up for cheaper than it ever was before

@KazeEspada
Copy link
Contributor

One word: Holoparasites.

Besides, you have no idea how to balance traitor. You campaigned to close the non-disarmable eswords because you whined you couldn't punch a fucking jedi as a untrained ass.

@Niknakflak
Copy link
Contributor

Other portions of badly balanced game mechanics are not a reason to say that this badly balanced mechanic is ok

@Iamgoofball
Copy link
Contributor Author

That's a fair point but quite frankly going by purchase ratings on those items:
Chameleon Jumpsuit: used in 15% of rounds (122 out of 807)
Voice Changer: used in 13% of rounds (108 out of 807)
Noslips: used in 19% of rounds (160 out of 807)

They're all sub 20%, especially the voice changer.

Compare this to shit like the emag, which is used in EVERY SINGLE ROUND WHERE THERE'S AN UPLINK, or the esword which is used in 81% of rounds, or the syndicate encryption key at 48% of rounds, or the fact that people buy RANDOM ITEMS more than they buy the 3 listed items above at around 22%.

There's no harm in buffing underused items and seeing how it goes.

Data gathered from here http://www.ss13.eu/tgdb/tg/latest_stats.html#uplinkitems
Yes, it's up to date, we maintain it still.

@Steelpoint
Copy link
Contributor

Good buff I think, these items are rarely used if ever (as noted). I don't think the price is a issue considering these items offer no real offensive bonus, the Laser Gun might fool some people but otherwise its pure obfuscation and defence.

@PKPenguin321
Copy link
Contributor

Good shit, goof. 👍

@CosmicScientist
Copy link
Contributor

Might I ask why little use means it's bad? I like what's being changed here but nothing needs to be a must buy to be... useful.

There's no harm in buffing underused items and seeing how it goes.

Doesn't that mean this will make it more used and then everything else that players think isn't an essential will be bought less and then we wind up back in the same situation, just a different PR?

@CosmicScientist
Copy link
Contributor

Oh and more statistics for fun!

Voice changer gas mask
It is used in 15% rounds with uplinks. (122 / 807)
It is used in 8% traitor rounds. (33 / 400)
It is used in 4% traitorchan rounds. (8 / 169)
It is used in 41% nuke rounds. (52 / 124)

Nuke ops love it and use the voice changer a lot.

Chameleon jumpsuit
It is used in 15% rounds with uplinks. (122 / 807)
It is used in 8% traitor rounds. (32 / 400)
It is used in 2% traitorchan rounds. (5 / 169)
It is used in 57% nuke rounds. (71 / 124)

Nuke ops love the jumpsuit more than the mask, probably because they can do it without the mask. Hell unless I'm getting the numbers wrong, they're sometimes bought by more than one person when they are bought.

No slip brown shoes
It is used in 19% rounds with uplinks. (160 / 807)
It is used in 24% traitor rounds. (99 / 400)
It is used in 9% traitorchan rounds. (16 / 169)
It is used in 8% nuke rounds. (10 / 124)
It is used in 0% revolution rounds. (1 / 114)

1 out of 4 tators agree, buying no slips is the way to go.

So if you're going to do this, the bundle at that price will be used a lot more as a whole rather than the component parts for their specific purposes as useful in specific situations.

@CosmicScientist
Copy link
Contributor

How about I drag something up that is sub 20%. The revolver, it's 16% overall, 18% in tator, 7% in tatorchang and 10% in nuke. Does that need a buff because its bought stats are low?

Again I like what you're doing here but I don't like the use of statistics as to why it should be buffed so dramatically.

@tkdrg
Copy link
Contributor

tkdrg commented Feb 21, 2016

Yeah, Cosmic makes a good point and I agree. Voice changer and chameleon jumpsuit sure, I could see these being bundled at maybe 3-4tc, but not fucking noslips. And 2tc is just ridiculous.

@Steelpoint
Copy link
Contributor

They are often used in Nuke Ops because, surprise, it's usually far easier to get where you need wearing a assistant's uniform with a gas mask than wearing a obvious red Nuke Op hardsuit.

If the whole thing is condensed into one package then the interested Ops will simply buy the package as it'll come with everything they need for a good disguise.

@Anonmare
Copy link
Contributor

Remove the no-slip from the shoes and make it 3 TC then it's 👍

@WJohn WJohn added Balance Changes to functionality that modifies how effective certain methods are at powergaming Feature Exposes new bugs in interesting ways labels Feb 21, 2016
@@ -1208,7 +1208,6 @@
#include "code\modules\mob\living\carbon\human\blood.dm"
#include "code\modules\mob\living\carbon\human\death.dm"
#include "code\modules\mob\living\carbon\human\emote.dm"
#include "code\modules\mob\living\carbon\human\examine.dm"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, why exactly this file was removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops

@Supermichael777
Copy link
Contributor

Does the mask have a clear mode so you can stealth evade say tear gas bombs?
also making it so that taping it with the agent id locks the look would be cool. imagine handing a dude a fake eva suit to "explore the derelict" then mass driving him.

@RemieRichards RemieRichards removed the Do Not Merge You must have really upset someone label Feb 23, 2016
return

target.desc = initial(picked_item.desc)
target.name = initial(picked_item.name)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name var always goes above desc in item defines you should move this line up

@Dorsisdwarf
Copy link
Contributor

Ooh, just realised.

You forgot to add dials to the description of the non-jumpsuit chameleon gear.

@Iamgoofball
Copy link
Contributor Author

Doesn't matter since the description gets nuked on the first change of appearance.

@KazeEspada
Copy link
Contributor

@Supermichael777 thats called a breath mask.

@Dorsisdwarf
Copy link
Contributor

It's not for sec meta, iamgoof, just a) consistency and b) reelissusms

@Iamgoofball
Copy link
Contributor Author

I need to remove the dial message from the jumpsuit, and I don't give a fuck about realism.

@Dorsisdwarf
Copy link
Contributor

It halps the nublets

think of the nublets

@Iamgoofball
Copy link
Contributor Author

They'll notice the big action buttons in the top left of their screen.

@PKPenguin321
Copy link
Contributor

one potential exploit i just noticed is that this stores a backpack in a box which i assume you can put into your backpack and can also hold more boxes with backpacks

@Iamgoofball
Copy link
Contributor Author

Nah, once you take something out it won't fit anymore.

@phil235
Copy link
Contributor

phil235 commented Feb 24, 2016

Will conflict with #15673 a lot.

@Firecage
Copy link
Contributor

Well, since you did increase the price, the only complaint I had is gone. 👍

…o PARANOIA

Conflicts:
	code/game/objects/items.dm
	code/modules/clothing/masks/gasmask.dm
	code/modules/clothing/under/chameleon.dm
@Dorsisdwarf
Copy link
Contributor

All my issues with this are gone, irrelevant, or changed-position-on, so 👍

for(var/V in chameleon_list)
var/obj/item/I = V
if(initial(I.name) == picked_name)
picked_item = V
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a break here, so we stop the "for" loop once we find a match.

@phil235
Copy link
Contributor

phil235 commented Feb 24, 2016

Also, the chameleon items do not inherit the flags of the item it tries to copy, especially cover_flags. This means you can copy a headgear that is supposed to cover your glasses but your copy doesn't cover the glasses, which gives your chameleon gear away. Is that intended?

I.item_state = initial(picked_item.item_state)
target.icon = initial(picked_item.icon)

C.regenerate_icons() //so our overlays update.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pretty heavy proc. It's not a pretty big deal but if you could find a way to call the appropriate updates, like only update_inv_head() when changing a headgear.

Maybe by checking which slot the item is in? So we only update your hand overlay when the item is in your hand, and call update_inv_backpack() when on your back, etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not without copypasting this shit and making 20 subtype datums for every single item.

@Iamgoofball
Copy link
Contributor Author

That's not intended, I'll make cover flags transfer

ChangelingRain added a commit that referenced this pull request Feb 25, 2016
A TEAM OF NUKEOPS DISGUISED AS THE HEADS OF STAFF
@ChangelingRain ChangelingRain merged commit 80c9101 into tgstation:master Feb 25, 2016
AKlimentyev pushed a commit to Shadowlightbackup/-tg-station that referenced this pull request Feb 27, 2016
@YPOQ YPOQ mentioned this pull request May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Changes to functionality that modifies how effective certain methods are at powergaming Feature Exposes new bugs in interesting ways
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet