Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tongues #16704

Conversation

Incoming5643
Copy link
Contributor

Adds tongues, which serve as the physical manifestation of speech impediments.

Sprites by @Cheridan

_"A Super Aggro Crag Request Pull"_™

🆑 Incoming5643
rscadd: Leading scientists have finally proven that humans (and xenos) in fact have tongues in their mouths.
rscadd: Swapping out tongues allows the various races to change their speech impediments. Putting a xeno tongue in someone allows them to make the hissing sound like a xeno whenever they speak.
experiment: Remember that tongues are stored in the MOUTH, selecting the head isn't good enough.
/:cl:

Adds tongues, which serve as the physical manifestation of speech impediments.
@RemieRichards
Copy link
Contributor

abductors don't have mouths nor tongues nerd.

@Incoming5643
Copy link
Contributor Author

I've not broken keyfabe

@@ -127,6 +127,10 @@
C.unEquip(thing)
if(exotic_blood)
C.reagents.add_reagent(exotic_blood, 80)
for(var/path in mutant_organs)
var/obj/item/organ/internal/I = new path()
I.owner = C
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this not I.Insert(C)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea, might explain some things.

@GunHog
Copy link
Contributor

GunHog commented Apr 7, 2016

Add a changeling one that you can give to people to grant them the ability to suck people dry.
EDIT: No xenomorph tongue-mouth? WJ and Chimera will be disappointed!

@Incoming5643
Copy link
Contributor Author

Tying ling abilities to organ systems the crew can steal is a long term goal of mine, but organ system code isn't quite there yet.

@Incoming5643 Incoming5643 changed the title Tongues [need sprites] [wipperoni] Tongues [need sprites] Apr 7, 2016
name = "tongue"
desc = "A fleshy muscle mostly used for lying."
icon_state = "lungs"
zone = "head"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why zone = "head" when you can actually put them in mouth? It's used by some of existing organs and organ manipulation for mouth is already a thing.

@Core0verload
Copy link
Contributor

At least one of the ling abilities is already tied to organ - it's thermal vision I think.

@Fox-McCloud
Copy link
Contributor

@Core0verload

More abilities should be, IMO---like hivemind, stasis, etc--right now most are just tied to the status of being a changeling or not.

@coiax
Copy link
Member

coiax commented Apr 7, 2016

So this means there's a tongue organ that you can remove? People can still talk without tongues, just deprives them of a lot of sounds

@octareenroon91
Copy link
Contributor

So loss of tongue gives an entire new impediment?

@WJohn WJohn added the Feature Exposes new bugs in interesting ways label Apr 7, 2016
@Alek2ander
Copy link
Contributor

Suiciding by biting off your tongue should drop the tongue.
Also, this is something that definitely needs food recipes.

@AnturK
Copy link
Member

AnturK commented Apr 7, 2016

👍 for the idea. Keep the abductor team separation please though.

var/rendered = "<i><font color=#800080><b>[user.name]:</b> [message]</font></i>"
for(var/mob/living/carbon/human/H in mob_list)
var/obj/item/organ/internal/tongue/T = H.getorganslot("tongue")
if(!T || T.type != type)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to check the 'team' of the tongue somehow, so that multiple ships of abductors can't hear eachother. Though I suppose that's kind of a feature.

@Incoming5643
Copy link
Contributor Author

there's no impediment for not having a tongue, you just can't talk.

if someone could figure out how to make a heavily edited accent to represent not having a tongue I'd be down with that though.

@coiax
Copy link
Member

coiax commented Apr 7, 2016

https://www.reddit.com/comments/ifflf/i_have_no_tongue_ama/

Can you speak?

Yes, I can speak fairly well. I had speech therapy for a year and my speech improved a lot, but I still have a lot of trouble with certain sounds. The "G" as in goat, "K" sound and the "ee" sound are the worst. Interestingly, I find that the more intelligent the person, the easier they can understand me.
For the D, N, T and TH sounds I use a special technique that has really helped me. I press my upper front teeth against my lower lip to produce the start of the sound. Depending on the sound, I vary the pressure applied to my lip. T requires the most, then D and least is N.
For the K sound, I use my throat to pronounce it, much like the Germans produce very throaty sounds in their laguage.
Finally, the G in goat is impossible for me to say and I have never been able to produce it.


/obj/item/organ/internal/tongue/abductor
name = "superlingual matrix"
desc = "A mysterious structure that allows for instantaneous and omnipresence communication between users. Pretty impressive until you need to eat something."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omnipresent

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, I think I've seen brain damaged abductors actually gibber out loud.

@Zilenan91
Copy link

As for organ plans big 👎 to letting crewmembers hear any kind of hivemind, this includes xeno and changeling, but everything else is fine.

@coiax
Copy link
Member

coiax commented Apr 8, 2016

But crew members can already hear the xeno hivemind with organ transplants, and binary chat with the binary encryption key.

@Zilenan91
Copy link

The binary key is fine because the borgs can tell everyone over comms if they want to and aren't immediately hostile.

Also I already said the xeno hivemind transplant, and it's the stupidest shit ever because Xenos are complete shit and letting people hear their plans and wherever they're going when one of them dies is just depressingly stupid game design combined with them bizarrely being less durable than even regular humans.

…es the actual hissing sound.

Moves the tongue organ to the mouth
Fixes up synth inheritances
Losing your tongue no longer makes you silent, but rather just makes you a lot harder to understand
Little misc things
@Incoming5643
Copy link
Contributor Author

Could be merged today save for lack of sprites

@Razoozle
Copy link
Contributor

Xeno tongue-mouth please. ;) And then maybe xeno head-biting. ;)

@PKPenguin321
Copy link
Contributor

xeno ;) tounge ;)i;)n ;;;)))my ;;)) ass ;;;;))))please. ;;;;;;;;;))))))))))

@Cheridan
Copy link
Contributor

@Incoming5643 Incoming5643 changed the title Tongues [need sprites] Tongues Apr 11, 2016
@Incoming5643
Copy link
Contributor Author

We should be good to go.

@ChangelingRain
Copy link
Contributor

Mime speaks? RIP OUT THE TONGUE!

@ChangelingRain ChangelingRain merged commit 28d543a into tgstation:master Apr 11, 2016
@Razoozle
Copy link
Contributor

@ChangelingRain Why did you remove the xeno hissing sound when it talks?

@Incoming5643
Copy link
Contributor Author

eh? They should still hiss, are they not hissing?

@Razoozle
Copy link
Contributor

No, you completely deleted the code for it. http://i.imgur.com/79ssVIc.png

@Incoming5643
Copy link
Contributor Author

it was moved to the xeno tongue

@Razoozle
Copy link
Contributor

Yes, but it doesn't work with normal xenos now. Can you add it back?
Or I could make a hotfix.

@Incoming5643
Copy link
Contributor Author

Xenos have the tongue so it should be working, I'll look into it

@Razoozle
Copy link
Contributor

You removed the hissing sounds from their saycode. They no longer make hissing sounds.

@Incoming5643
Copy link
Contributor Author

But I put it in their tongue, which is called from carbon/treat_message

I'm going to guess that aliens don't call treat_message.

@Razoozle
Copy link
Contributor

I'm making a hotfix. I'm guessing you removed that code because if their tongue is removed they can't hiss anymore?

@Incoming5643
Copy link
Contributor Author

The alien should call treat_message, which should call their tongue, which should produce the hiss.

There's nothing special about how aliens talk compared to other carbons (alien_talk is for hivemind), so maybe it's just a matter of the sound not being heard for some reason.

@Razoozle
Copy link
Contributor

No, it is completely removed. I had to use the *hiss emote to even make a hissing sound.

@Razoozle
Copy link
Contributor

#16864

/obj/item/organ/internal/tongue/abductor
name = "superlingual matrix"
desc = "A mysterious structure that allows for instant communication between users. Pretty impressive until you need to eat something."
icon_state = "tongueayylmao"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pff

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Exposes new bugs in interesting ways
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet