Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed job slot counts #5202

Merged
merged 4 commits into from Oct 17, 2014
Merged

Changed job slot counts #5202

merged 4 commits into from Oct 17, 2014

Conversation

ghost
Copy link

@ghost ghost commented Oct 11, 2014

  • Added a roboticist slot for roundstart (so two can spawn roundstart as robo, maximum is still two)
  • Added another maximum slot for cargo techs (there can now be 3 total by default, but only 2 spawn at roundstart)
  • Added changelog for assistant maint being removed

@Incoming5643
Copy link
Contributor

Added changelog for assistant maint being removed

You fucking wot?

@RemieRichards
Copy link
Contributor

bugfix: "Removed assistant maintenance access."

hahahahahaha

bugfix

@Incoming5643
Copy link
Contributor

First of all the changelog is seen by more than us, so you can't announce someone changing a preference there.

Second of all, no.

@ghost
Copy link
Author

ghost commented Oct 11, 2014

Uh yes other servers using our codebase should not be using our changelogs in the first place and second of all scaredy changed the option on the servers and I was told it was an important thing to changelog. I really doubt it'll be something that affects other codebases anyway, this is for our server and people are very confused by the lack of assitant maint.

@Incoming5643
Copy link
Contributor

SoS seriously changed the setting on a +/- 5% shitshow poll?

@ghost
Copy link
Author

ghost commented Oct 11, 2014

Incoming if you'd like to discuss your maximum asshurt over democracy please join #coderbus

@Incoming5643
Copy link
Contributor

Nah I'm just gonna go play more smash, just be ready for what comes next in terms of player sentiment

@ghost
Copy link
Author

ghost commented Oct 11, 2014

This isn't the place to discuss your opinion, shitpost elsewhere

@ghost
Copy link
Author

ghost commented Oct 12, 2014

people are very confused by the lack of assitant maint.

I wonder why.

@Kraseo

This comment was marked as abuse.

@Atskadan
Copy link
Contributor

Incoming if you'd like to discuss your maximum asshurt over democracy please join #coderbus

when did you turn into rock

@ghost
Copy link
Author

ghost commented Oct 12, 2014

Kraso and miggles shitposting in sync, nothing new here, back to #advocateshortbus plz

@Atskadan
Copy link
Contributor

paprika man why are you always so salty
how do you find time to enjoy life when you get so mad at everyone all the time

@ghost
Copy link
Author

ghost commented Oct 12, 2014

rofl 🍌

@Cheridan
Copy link
Contributor

Like Incoming said, it doesn't make sense to include preference option changes on the changelog. The way downstream servers do their changelogs, from what I've seen, is they simply add their changes into our changelog. After all, the stuff we add is also added to their codebase.

@Aranclanos
Copy link
Contributor

remove that changelog entry about a server configuration change that is not related to this PR, I'm even asking admins to correct people if they start blaming coders for the change.

@ghost
Copy link
Author

ghost commented Oct 12, 2014

Alright then.

@Aranclanos
Copy link
Contributor

Okay. The next stupid commit log that I see from you I'll personally close the PR.

@ghost
Copy link
Author

ghost commented Oct 12, 2014

ss 2014-10-11 at 09 03 06
ss 2014-10-11 at 09 02 45
ss 2014-10-11 at 09 01 56

Are you autistic just most of the time or all of the time?

@Aranclanos
Copy link
Contributor

cherrypicking

yeah I'll close your next PR with stupid commit logs.

@ghost
Copy link
Author

ghost commented Oct 12, 2014

but you'll merge this wonderful PR right??? 🔨

@Aranclanos
Copy link
Contributor

3 commits for 3 line changes

how do you do this

@optimumtact
Copy link
Member

Honestly do the players even look at the changelog?

@Atskadan
Copy link
Contributor

yeah

@theOperand
Copy link
Contributor

I think the feedback forums forums leaking out again.

@Steelpoint
Copy link
Contributor

Slot changes seem reasonable and don't change anything significantly. Good job there.

On the changelog issue, I do think adding a log of Assistant maintenance access being removed is a good thing. It would at least show some form of official statement of removal.

@ghost
Copy link
Author

ghost commented Oct 12, 2014

I REALLY DON'T CARE THIS PR NO LONGER HAS ANYTHING TO DO WITH ASSISTANT MAINT OK.

@ghost ghost closed this Oct 16, 2014
@ghost ghost reopened this Oct 16, 2014
Cheridan added a commit that referenced this pull request Oct 17, 2014
@Cheridan Cheridan merged commit 7764393 into tgstation:master Oct 17, 2014
@ghost ghost deleted the roboslots branch January 16, 2015 00:38
tortellinitony pushed a commit to tortellinitony/tgstation that referenced this pull request Dec 9, 2017
…3244

[MIRROR] Adds server tools version to feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants