Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acid Rework #5512

Merged
merged 7 commits into from
Nov 4, 2014
Merged

Acid Rework #5512

merged 7 commits into from
Nov 4, 2014

Conversation

RemieRichards
Copy link
Contributor

Changes:

  • /acid type reagents have had their reacts rewritten to pass it on to an acid_act() proc.
  • This proc handles the melting of items and the melting of each equipped piece of armour and the melting of the mob's limbs (if human)
  • Adds admin spawn premade pacid grenades (see gif)

Layered Acid Protection TM:

Acid damage is now PER LIMB instead of "Your head didn't protect you? Let's burn your legs and arms"
This Damage is stopped individually if an appropriate piece of clothing exists above it.
A piece of clothing is deemed appropriate if it has ANY armour values remaining.
When clothing protects a limb from acid, it lowers it's protection values.
protection happens in a sort of layering/hierarchy in that things that are worn above other clothing items are checked first.

Eg:
HEAD --> MASK --> GLASSES
And, SUIT --> UNIFORM

Also adds a sort of useless helper that while is not used in this PR, was deemed potentially useful.

Layered Acid Protection:

…f opposed by a piece of clothing.

Pieces of clothing now reduce in protection when surviving an acid attack.
added a potentially useless helper.
@GunHog
Copy link
Contributor

GunHog commented Oct 28, 2014

Which items have an immunity to this effect?

@RemieRichards
Copy link
Contributor Author

Any flagged with "unacidable" which, atm I don't have a clue, I couldn't list them.
(if my Xenoacid blood PR goes through, all the shoes in that PR will be immune)

@Incoming5643
Copy link
Contributor

A robed wizard's worst nightmare

@theOperand
Copy link
Contributor

I suggest making the telearmor unacidable
Op 28-okt.-2014 09:06 schreef "Incoming5643" notifications@github.com:

A robed wizard's worst nightmare


Reply to this email directly or view it on GitHub
#5512 (comment)
.

@RemieRichards
Copy link
Contributor Author

@Miauw62 "Telearmor"? Do you mean the reactive teleport armour?

@theOperand
Copy link
Contributor

Yeah

On Tue, Oct 28, 2014 at 6:04 PM, Remie Richards notifications@github.com
wrote:

@Miauw62 https://github.com/Miauw62 "Telearmor"? Do you mean the
reactive teleport armour?


Reply to this email directly or view it on GitHub
#5512 (comment)
.

@optimumtact
Copy link
Member

Probably worth making wiz clothes unacidable, since he needs them for spellcasting iirc

@RemieRichards
Copy link
Contributor Author

Yeah fair enough, Tele needs it since it wouldn't be hit by the acid because it teleported away and wizards are magic

@Steelpoint
Copy link
Contributor

Pretty cool, not only that but it paves the way for this feature to be worked into other areas. Also since I was told armour will tell you if its been damaged...

👍

@RemieRichards
Copy link
Contributor Author

Will fix conflicts when I get home.

…o AcidBurns

Conflicts:
	code/game/atoms.dm
	code/game/objects/items.dm
@RemieRichards
Copy link
Contributor Author

@tgstation/commit-access conflictus fixus.

@hornygranny hornygranny merged commit e662932 into tgstation:master Nov 4, 2014
tortellinitony pushed a commit to tortellinitony/tgstation that referenced this pull request Dec 22, 2017
…3681

[MIRROR] Immovable rod abuse, smite and event trigger.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants